Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from url-pattern to path-to-regex #1988

Closed
zachleat opened this issue Sep 28, 2021 · 2 comments
Closed

Switch from url-pattern to path-to-regex #1988

zachleat opened this issue Sep 28, 2021 · 2 comments
Labels
enhancement feature: 🏙 serverless Eleventy Serverless
Milestone
Eleventy 1.0.0

Comments

@zachleat
Copy link
Member

In the interest of 1.0 timelines and as an alternative to #1954, switch to https://github.com/pillarjs/path-to-regexp instead as a smoother transition step if urlpattern-polyfill isn’t gonna fit the timeline.

Reasoning here is that path-to-regexp is the basis for the URLPattern syntax https://github.com/WICG/urlpattern/blob/main/explainer.md#urlpattern
@zachleat zachleat added this to the Eleventy 1.0.0 milestone Sep 28, 2021
@zachleat zachleat mentioned this issue Sep 28, 2021
Closed
@zachleat
Copy link
Member Author

Shipping with Canary 45

zachleat added a commit to 11ty/11ty-website that referenced this issue Sep 28, 2021
@zachleat
Updated lib in 11ty/eleventy#1988
5f4c8a4
@zachleat
Copy link
Member Author

zachleat commented Oct 7, 2021

Canary 45 ended up not being a thing. Instead, it shipped with 1.0.0-beta.1

@timonforrer timonforrer mentioned this issue Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature: 🏙 serverless Eleventy Serverless
Projects
None yet
Milestone
Eleventy 1.0.0
Development

No branches or pull requests
1 participant
@zachleat