Fix syntax error in cice_runmod.F90 by removing continuation #6
Conversation
|
The syntax error described in #5 also exists in other branches, such as |
|
The change looks good :) Is the plan to keep the access-esm1.5 branch long term? Can we merge it with the main branch? Why are we discovering this now? esm1.5 obviously already exists and can be built etc ... |
|
@anton-seaice The released versions of ACCESS-ESM1.5 still use the Th reason why we are not hitting this problem all the time is that we are still using the 2019 version of the Intel Fortran compiler, and the issue was discovered when using the 2021 compiler. See issue #5 |
There was a problem hiding this comment.
Thanks for the extra info.
Current builds use the %[email protected] compiler version (see - https://github.com/ACCESS-NRI/ACCESS-ESM1.5/blob/ee2345b33729473804d1c75f022feac3ea541a71/spack.yaml#L46) which compiles without this change. For support of new compilers, we need to fix this change.
I built current branch
spack install [email protected]%[email protected] arch=linux-rocky8-x86_64
-> success
I tried current branch with newer compiler
spack install [email protected]%intel2021.10.0 arch=linux-rocky8-x86_64
-> failed - per this issue
I built from this PR:
spack install cice4@3de3702cd27922cd77709d68075922a37302cbb6%[email protected] arch=linux-rocky8-x86_6
-> success
penguian
force-pushed
the
5-syntax-error-in-cice_runmod-f90
branch
from
3de3702 to
a2ca8da
Compare
|
I signed the most recent commit on the local branch using then force pushed the local branch using The commits compare as identical: https://github.com/ACCESS-NRI/cice4/compare/3de3702cd27922cd77709d68075922a37302cbb6..a2ca8da8632632339501d5bf23124356d15ec70b |
Closes #5 for the
access-esm1.5branch.The code change has been tested by building the
cice4Spack package using the5-syntax-error-in-cice_runmod-f90branch instead ofaccess-esm1.5, and the package builds successfully using both%[email protected]and%[email protected].