Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated message to guild chat #36

Open
ashayo opened this issue Oct 19, 2014 · 2 comments
Open

Truncated message to guild chat #36

ashayo opened this issue Oct 19, 2014 · 2 comments
Assignees

Comments

@ashayo
Copy link

ashayo commented Oct 19, 2014

Long messages are sometimes truncated. (Only noticed because multi-boxing. Reproduced what guildie sent and got same result)
Reproducible example with 3 linked items:
Note that guildie probably meant "lol" at end, but reached max guild message size.

Guild chat:
17:09:10 [Mytoonname-EarthenRing]: so my first bag of the holiday: [Magic Broom] [Hallowed Helm] [The Horseman's Sinister Slicer] l

What was sent to channel:
17:09:11 [Mytoonname-EarthenRing]: C#verendus##so my first bag of the holiday: [Magic Broom] [Hallowed Helm]

Error user receives:
GreenWall: [ERROR] Message corruption detected. Please disable add-ons that might might modify messages on channel 4

(there are no addons modifying channel)

@mrogaski mrogaski added the bug Something isn't working label Oct 20, 2014
@mrogaski mrogaski added this to the Patch 1.5.2 milestone Oct 20, 2014
@mrogaski mrogaski self-assigned this Oct 20, 2014
mrogaski added a commit that referenced this issue Oct 24, 2014
Added Base32Hex library to allow eight flags in a single ASCII digit. (#36)
mrogaski added a commit that referenced this issue Nov 13, 2014
Added message segmentation to handle message overhead. (#36)
Fixed luadoc for utility functions. (#37)
@mrogaski mrogaski modified the milestones: Major Release 2.0, Minor Release 1.6.0 Feb 5, 2015
@mrogaski mrogaski added enhancement and removed bug Something isn't working labels Apr 13, 2016
@mrogaski mrogaski modified the milestones: Accepted, v2.0.0 Apr 13, 2016
@Torsin
Copy link

Torsin commented Sep 5, 2017

Yep, still getting this:

[P] [Paandel]: (914.4) [Perpetual Leftovers] 
[O] [Torsin]: [Runescale Koi][Stormray][Highmountain Salmon][Stonedark Snail][Leyblood]

I assume it has to do with the length of the tag needing to be added to the guild chat to denote a message from the other guild? Perhaps you could detect a string over a certain length and split it across multiple sends to the other guild? Similar to:

		if (string.len(chatMsg) > 510) then
			SendChatMessage(string.sub(chatMsg, 1, 255), channel, nil, nil);
			SendChatMessage(string.sub(chatMsg, 256, 510), channel, nil, nil);
			SendChatMessage(string.sub(chatMsg, 511), channel, nil, nil);
		elseif (string.len(chatMsg) > 255) then
			SendChatMessage(string.sub(chatMsg, 1, 255), channel, nil, nil);
			SendChatMessage(string.sub(chatMsg, 256), channel, nil, nil);
		else
			SendChatMessage(string.sub(chatMsg, 1), channel, nil, nil);
		end

@mrogaski
Copy link
Member

mrogaski commented Sep 5, 2017

Version 2 will allow messages to be segmented, which will fix this.

@mrogaski mrogaski removed this from the Accepted milestone Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants