Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical upgrade and new features #17

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

guihome-diaz
Copy link

Hi,

Thanks a lot for your API ! This is very helpful, and I am happy to use it for my projects.

I did some changes to your base code:

  • Upgrade to Java 8 (only in POM, I didn't change the core classes)
  • I added a "singleton" like pattern for the applications that don't use Spring or equivalent. It will avoid reloading the library at runtime
  • I added the option to load multiple files at once, this can come in handy for some projects of ours
  • I added a toString() to the GeoName class to display the "city [country]". we don't care about a detailed position
  • I added unit tests. Coverage jumped from 0% to 94% ;)
  • I added some Travis and Codacy configuration

Don't hesitate to contact me back and react if you have questions. I'm sorry for the ugly merge quality, I forgot to remove my Eclipse "save actions".

Have a nice day,
GuiHome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant