-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dev mode and instant sealing mode #2702
Comments
are we going to completely remove instant-sealing mode? I think it's still useful in some scenarios, such as large scale deterministic tests (i.e. bodhi CI). These tests don't rely on mainnet status, and are faster to run on local instant-sealing mandala node |
we can just use Chopsticks to launch a dev chain from a chain spec file. |
sure, we can definitely try it out to see how it goes. My main concern is that light client could slow down the whole tests a little bit. But we will see, might not be an actual issue |
there is no light client? Chopsticks is slow mostly because it need to download state from remote RPC. in this case, there are no remote RPC so it shouldn't be too slow |
oh chopsticks is not considered to be a "light client"? Maybe I was confused about the definition. But as long as it's fast without needs to fetch remote RPC, it should work well |
light client is a client that verify consensus without downloading and executing all the data. chopsticks is only a mock client that it doesn’t verify anything at all chopsticks is using some code from smoldot and smoldot implements light client |
We can use Chopsticks instead to launch node from chain spec
Need to update existing tests that using dev mode
The text was updated successfully, but these errors were encountered: