-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do we need to enumerate all applicableUnit? #29
Comments
I know Passi made the point that the ontology should assume SI unit and it is the responsibility of UI to translate to/from that unit. |
For the Ramp example, I looked up the relevant IFC property:
That's measured in radian in IFC, so when comparing we have to use that unit:
But even if we limit to SI, a property will have a choice of |
Agree we should have choice - but my view is the choice should be based on what the regulation says, and it is a processing engine's job to translate that to what is in the IFC |
Agreed, we should be true to the regulation text. - $id: quantity/FI/accessibility/ramp/gradient
ifcProperty: ifc:requiredSlope_IfcRamp # not sure about name
rdfs:range: ifc:IfcPlaneAngleMeasure
unit: unit:RAD # from QUDT
- $id: regulation/FI/accessibility/2.2.3.4.2
quantity: quantity/FI/accessibility/ramp/gradient
comparison: comparison/GT
value: 5
unit: unit:GR # from QUDT "Grade: the tangent of an angle of inclination multiplied by 100" Then the engine needs to:
|
The original question has been answered: qudt/qudt-public-repo#720 and https://github.com/qudt/qudt-public-repo/wiki/Advanced-User-Guide#4-computing-applicable-units-for-a-quantitykind.
I think we should describe this in prop documentation. I've suggested some edits in qudt/qudt-public-repo#720 |
aec3po:ModularRoomHeight and aec3po:WidthOfAngledCorridor only list a small set of S.I. applicable units. this restricts the set of units from quantitykind:Length. However currently aec3po:CompressiveForce just defines the same set of applicable units as the broader quantitykind:Force, so it may be omitted. solved in commit 96d0f6f Am I right to assume the DimensionVector of a quantity kind should also be computable from the broader quantity kind ? |
The dimension vector should be the same, yes |
So can we avoid expliciting this metadata ? |
We can and we should, otherwise it will be a nightmare to maintain. Changing to "bug" |
Do we need to enumerate all applicableUnit, or are they "inherited" from the parent QuantityKind?
qudt:applicableUnit
inherited along the QuantityKind hierarchy? qudt/qudt-public-repo#720. It seems no inheritance happens in QUDT, so we do needaec3po/src/quantity_kinds.ttl
Lines 52 to 57 in 5fb6f7e
The text was updated successfully, but these errors were encountered: