Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for easier usage of BankIdClient when used without the ASP.NET Core pipeline #235

Open
PeterOrneholm opened this issue May 7, 2020 · 2 comments
Labels
enhancement New feature or request NewArchitecture New Architecture aimed for V5.0

Comments

@PeterOrneholm
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The BankID API wrapper is today a separate package, which allows for using it without the Active Login authentication flow / UI found in ActiveLogin.Authentication.BankId.AspNetCore. The BankIdClient takes a mandatory HttpClient in the constructor. For BankId to work, you need to configure this HttpClient with certificate(s) and BaseUri for it to work. This can be made easier.

I would like it to be easy to create an instance of the BankId client given that you have:

  • API Url (Production or test, already available as constants)
  • Client certificate
  • Optional: CA certificate to validate against

What area is it related to

  • ActiveLogin.Authentication.BankId.Api

Describe the solution you'd like
Not exactly sure on the most optimal implementation, but I'm leaning towards an BankIdHttpClientBuilder. We could then add extension methods similar to what we already have for the AspNetCore package. Maybe we can even restructure that one to use the same builder. In addition we could add an extension method to the BankIdClient class to allow for creating it from there.

A solution could look something like this:

var bankIdClient = BankIdClient.Build(builder => {
  builder.UseProductionEnvironment()
             .UseClientCertificate(...)
             .UseRootCaCertificate(...)
 });
@PeterOrneholm PeterOrneholm added the enhancement New feature or request label May 7, 2020
@PeterOrneholm PeterOrneholm added this to the 5.0.0 milestone May 15, 2020
@PeterOrneholm PeterOrneholm added the NewArchitecture New Architecture aimed for V5.0 label May 18, 2020
@PeterOrneholm PeterOrneholm removed this from the 5.0.0 milestone Jan 17, 2022
@PeterOrneholm PeterOrneholm added this to the 6.0.0 milestone Mar 21, 2022
@PeterOrneholm
Copy link
Collaborator Author

The refactorings in 6.0.0 have made this possible, but we will have to push the docs/helpers to take it all the way to 7.0.0.

@PeterOrneholm PeterOrneholm modified the milestones: 6.0.0, 7.0.0 Jun 3, 2022
@PeterOrneholm PeterOrneholm modified the milestones: 7.0.0, 8.0.0 Apr 24, 2023
@PeterOrneholm PeterOrneholm modified the milestones: 8.0.0, 9.0.0 Dec 19, 2023
@PeterOrneholm PeterOrneholm removed this from the 9.0.0 milestone Apr 17, 2024
@elinohlsson
Copy link
Contributor

Is there anything remaining to do, to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NewArchitecture New Architecture aimed for V5.0
Projects
None yet
Development

No branches or pull requests

2 participants