Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum required Java version to 11 #3277

Open
kwin opened this issue Feb 26, 2024 · 3 comments
Open

Raise minimum required Java version to 11 #3277

kwin opened this issue Feb 26, 2024 · 3 comments

Comments

@kwin
Copy link
Contributor

kwin commented Feb 26, 2024

As ACS AEM Commons only supports AEM 6.5.(10) and AEM as a Cloud Service and the former optionally runs on Java 11 while the latter runs by default on Java 11 I think we should drop support for Java 8.

That allows to leverage new language features like Streams, Http Client (#3276) and probably reduce the usage of thirdparty libraries like Google Guava.

@kwin
Copy link
Contributor Author

kwin commented Feb 26, 2024

@davidjgonzalez and @YegorKozlov WDYT?

@YegorKozlov
Copy link
Contributor

@davidjgonzalez and @YegorKozlov WDYT?

Requiring Java 11 is fine to me, especially if it helps to make the code leaner and cleaner. Conservative users running on JDK 1.8 will need to either upgrade JDK or use older releases.

There can be many reasons why people are still on JDK 1.8, like legacy code that require java.xml.ws, java.activation or whatever else was removed in JDK 11, but none of these is a reason why we should support JDK 1.8.
It's been two years since 1.8's EOL and it's time to upgrade.

@davidjgonzalez
Copy link
Contributor

davidjgonzalez commented Mar 22, 2024

Fine with me as well. There have been many years for users to switch to later versions of Java.

This would bump us to 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants