Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Setter applies graphics settings on every map after the last map that wanted to change graphics settings #154

Closed
TheBlackParrot opened this issue Feb 22, 2025 · 0 comments
Labels
mod: heck status: confirmed Bug confirmed type: bug Something isn't working

Comments

@TheBlackParrot
Copy link

Running into this trying to fix something with NoteTweaks (TheBlackParrot/NoteTweaks#24), and I'm noticing this line appearing in logs every time I start a map after accepting Settings Setter wanting to change some graphics settings.

[INFO @ 17:33:43 | UnityEngine] Applied performance preset [HeckPresetOverride]

Fetching values from the MainEffectContainer object that controls bloom will always return whatever was set previously, through Settings Setter.

If I start the game fresh:

[INFO @ 17:38:32 | UnityEngine] Applied performance preset [Unknown Preset]

and stuff works as expected

To Reproduce

  1. Play any map that doesn't change graphics settings
  2. Observe console logs
  3. Play any map that does change graphics settings (e.g. https://beatsaver.com/maps/44384)
  4. Play another map that doesn't change graphics settings
  5. Observe console logs, see issue pop up

Notes
Observed this in 1.37.1, didn't test other versions

@Aeroluna Aeroluna added type: bug Something isn't working status: confirmed Bug confirmed labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: heck status: confirmed Bug confirmed type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants