Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampling interface additions #1449

Open
cyrush opened this issue Jan 30, 2025 · 2 comments
Open

sampling interface additions #1449

cyrush opened this issue Jan 30, 2025 · 2 comments

Comments

@cyrush
Copy link
Member

cyrush commented Jan 30, 2025

For uniform grid:

  • Allow spatial extents to be specified as an alternative to origin and spacing. This from will be more natural for many use cases
  • Allow fields in addition to field, and support sampling multiple fields.
@cyrush cyrush changed the title uniform grid sampling interface additions sampling interface additions Mar 4, 2025
@cyrush
Copy link
Member Author

cyrush commented Mar 4, 2025

Expand sampling cases beyond uniform grids, with a generic "sample" filter.

We should provide an interface that mirrors clip (perhaps expanded to also include the seed patterns in the streamline filter)

  • box (this basically is our uniform grid filter)
  • line (not in clip, but perhaps should be)
  • plane
  • sphere
  • cylinder
  • mesh: allow users to provide a blueprint mesh to sample onto

Like current sampling - start with results only on rank 0 (this is the most pressing use case)

@cyrush
Copy link
Member Author

cyrush commented Mar 4, 2025

@nicolemarsaglia I updated this ticket with ideas about expanding how we leverage sampling to provide users more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant