Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header menu element for library in Studio #14203

Open
standeren opened this issue Nov 28, 2024 · 3 comments · Fixed by #14478 · May be fixed by #14491
Open

Add header menu element for library in Studio #14203

standeren opened this issue Nov 28, 2024 · 3 comments · Fixed by #14478 · May be fixed by #14491
Labels
team/studio-domain1

Comments

@standeren
Copy link
Contributor

standeren commented Nov 28, 2024 •
edited
Loading

Description

Add a new menu element in the Studio header for accessing the library. The menu element should enable the beta tag.

Here is the config to add to headerMenuUtils.ts:

{
    key: HeaderMenuItemKey.ContentLibrary,
    link: RoutePaths.ContentLibrary,
    icon: BookIcon,
    repositoryTypes: [RepositoryType.App],
    group: HeaderMenuGroupKey.Tools,
    isBeta: true
  },

In order to announce the library as releaseable we should also either:

  1. Remove the images library menu element by delete it from the incoming pages in AppContentLibrary.tsx, or
  2. Adapt the information alert in the images library page to inform that this section will be implemented soon.
    This question is probably something @Annikenkbrathen can answer? 😊

We also need a news section for this release. Maybe @Ildest can contribute to formulating one? 🙏

To consideration

Should we call the menu element Appbibliotek as this implementation of the library is only in app context and not for organizations, or is this intuitive?

Additional Information

⚠ Currently the beta functionality is a bit buggy after removing asChild property from the StudioHeaderMenu elements. This should be fixable by exploiting pure css; :after on the class and content: Beta in the class, in addition to the other css needed to maintain the design (remember to use css variables from DS Tag component to maintain same css) . This css class should only be be set when the menu element has isBeta prop set.

Image

Tasks

No response

Acceptance Criterias

No response
@standeren standeren added the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Nov 28, 2024
@Annikenkbrathen
Copy link

I think we should include the image section in the library, so it’s clear that more is coming. After all, it’s a beta.
Maybe we could rephrase the message in the alert a bit to make it clear to users that this is something coming soon. what do you think @Ildest? ☺️

My suggestion:
"Snart blir det mulig å laste opp bilder i biblioteket. Vi jobber med saken!"

Image

Should we add the beta tag to the library itself as well, for example here?
Image

@Ildest Have you gone through all the texts in the library, or would you like to review how it looks in dev regarding the content? We could create a task for that if needed

@Ildest Ildest moved this to 👷 In Progress in Team Studio Nov 28, 2024
@Ildest Ildest self-assigned this Nov 28, 2024
@Ildest
Copy link
Contributor

Ildest commented Nov 28, 2024

I think we should include the image section in the library, so it’s clear that more is coming. After all, it’s a beta. Maybe we could rephrase the message in the alert a bit to make it clear to users that this is something coming soon. what do you think @Ildest? ☺️

My suggestion: "Snart blir det mulig å laste opp bilder i biblioteket. Vi jobber med saken!"

Image

Should we add the beta tag to the library itself as well, for example here? Image

@Ildest Have you gone through all the texts in the library, or would you like to review how it looks in dev regarding the content? We could create a task for that if needed

First, you suggested text above is good to go @Annikenkbrathen :-). Second, yes I would like to review it with you in dev, so I am sure - it´s been a while since these texts were created, and things may have changed. Also, I will be easier fro me to contribute a news text that @standeren asked for in another task, if we look at this first.

@Ildest
Copy link
Contributor

Ildest commented Nov 29, 2024 •
edited
Loading

@standeren @nkylstad

News snippet suggestion:

Vi har lagd et nytt bibliotek! Her finner du nå kodelistene dine. Vi jobber med å utvide biblioteket slik at du også kan finne og lagre andre ting der, for eksempel bilder og tekster.

@Ildest Ildest removed their assignment Nov 29, 2024
@framitdavid framitdavid moved this from 👷 In Progress to 📈 Todo in Team Studio Jan 8, 2025
@standeren standeren self-assigned this Jan 21, 2025
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Jan 21, 2025
@standeren standeren mentioned this issue Jan 21, 2025
Merged
2 tasks
@standeren standeren linked a pull request Jan 21, 2025 that will close this issue
fix: display beta tag with css #14478
Merged
2 tasks
@standeren standeren removed the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Jan 22, 2025
@standeren standeren linked a pull request Jan 22, 2025 that will close this issue
Open
3 tasks
@standeren standeren linked a pull request Jan 22, 2025 that will close this issue
feat: add library as beta to studio page header with news #14491
Open
3 tasks
@github-project-automation github-project-automation bot moved this from 👷 In Progress to Documentation in Team Studio Jan 27, 2025
@standeren standeren reopened this Jan 27, 2025
@standeren standeren moved this from Documentation to 👷 In Progress in Team Studio Jan 27, 2025
@wrt95 wrt95 moved this from 👷 In Progress to ⚠️ Blocked in Team Studio Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/studio-domain1
Projects
Team Studio
Status: ⚠️ Blocked
Milestone
No milestone
3 participants
@standeren @Annikenkbrathen @Ildest