Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratio Bar in Userscript Not Showing/Unconfigurable #1118

Open
1 task done
CuboidRaptor opened this issue Jan 16, 2025 · 3 comments
Open
1 task done

Ratio Bar in Userscript Not Showing/Unconfigurable #1118

CuboidRaptor opened this issue Jan 16, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@CuboidRaptor
Copy link

CuboidRaptor commented Jan 16, 2025

Have you tried to find similar issues (open or recently closed)?

  • Yes, this issue is not a duplicate

Browser

Firefox Latest

Browser Version

134.0 64-bit

Extension or Userscript?

Userscript

Extension/Userscript Version

3.1.5

Video link where you see the problem

All

What happened?

By default, the ratio bar underneath the like/dislike counter is disabled for the userscript. (At least, for me.) So, it doesn't show. There is a config object in the code, however it can't be modified without disabling updates as a newer update would overwrite the config. The ratio bar does appear when the config is set. (though it's false by default)
So, is there a way to configure it? Or, enable the ratio bar by default?
I am using Violentmonkey.
(Fedora 41 if that matters.)

How to reproduce/recreate?

Install userscript

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

@CuboidRaptor CuboidRaptor added the bug Something isn't working label Jan 16, 2025
@jpa102
Copy link

jpa102 commented Jan 18, 2025

i can reproduce on my end

Image

chrome 109.0.5414.168 (Official Build) (64-bit)

violentmonkey 2.29.0

userscript version 3.1.5

there's something that prevents the ratio bar from showing up, which is the TrustedHTML

i made a fork of the userscript before, and adding the necessary code for TrustedTypes fixes it

Image

this is how i implemented the code in the userscript:

Image

@CuboidRaptor
Copy link
Author

For me, the ratio bar works fine as long as I set rateBarEnabled to true in the extConfig. (without using the trustedHTML fix.) However, configuring anything in the extConfig disables updates, which is what I'm concerned about.

@jpa102
Copy link

jpa102 commented Jan 20, 2025

now i see what you mean, i didn't read the entire post

i think that's how it works

Auto-updated script is read-only unless you disable updates or allow editing.

probably one of the devs who worked on it have set it to be disabled by default for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants