Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce expression button feature #124

Open
PanHoracy opened this issue Aug 4, 2023 · 3 comments
Open

Reintroduce expression button feature #124

PanHoracy opened this issue Aug 4, 2023 · 3 comments
Labels
Feature✨ New feature or request

Comments

@PanHoracy
Copy link

Are they any chances of reintroducing expression buttons, or something that would fill its role?

Is your feature request related to a problem? Please describe.
I often used older versions of Panku to quickly create runtime debug menus, that I would use instead of creating temporary UI just for this sake.

Describe the solution you'd like
It could be implemented in expression monitor, as some additional button when editing an expression that would convert it from monitor to button. The other approach would be to create a new module for it, which could be dedicated just for that. One could be a bit cumbersome, or bloat expression monitor, the second would require more time I presume.

Describe alternatives you've considered
I considered creating a module just for myself, or to edit the current implementation of expression monitor, but I figured I might as well ask before doing that, If there are chances/plans for return of that feature.

@Ark2000 Ark2000 added the Feature✨ New feature or request label Aug 12, 2023
@Ark2000
Copy link
Owner

Ark2000 commented Aug 12, 2023

Have you tried the data controller? It is good at creating quick UI, I believe it will suit your needs.

@PanHoracy
Copy link
Author

The data Controller can be useful, but not in every situation. Adding things to it adds clutter to the inspector, especially if you have many things that you want to control with it.

Sometimes you need to use some expressions or run some functions, or when debugging, you have to create quick access to some expressions, that you didn't program before, and you won't use later either. I guess the better tool that can go in place of it is using keyboard shortcuts. This, though, is not very ergonomic when dealing with a bigger amount of expressions that you want to use.

Anyway, I did look into the expression monitor implementation, and hacked buttons into it. It was fairly easy, not ideal though, as expression monitor wasn't coded to handle those, but it works for me.

A little GIF of how it works (and how I would imagine it would be implemented, if it were to be):
buttons_mockup

@Ark2000
Copy link
Owner

Ark2000 commented Aug 15, 2023

The data Controller can be useful, but not in every situation. Adding things to it adds clutter to the inspector, especially if you have many things that you want to control with it.

Sometimes you need to use some expressions or run some functions, or when debugging, you have to create quick access to some expressions, that you didn't program before, and you won't use later either. I guess the better tool that can go in place of it is using keyboard shortcuts. This, though, is not very ergonomic when dealing with a bigger amount of expressions that you want to use.

Anyway, I did look into the expression monitor implementation, and hacked buttons into it. It was fairly easy, not ideal though, as expression monitor wasn't coded to handle those, but it works for me.

A little GIF of how it works (and how I would imagine it would be implemented, if it were to be): buttons_mockup

Thanks for your effort! Currently your solution is to add an add button button image to all groups, but there's a play button image to start/stop monitoring expressions, which may cause confusion. My suggestion is to add a new button at the bottom called Add New Button Group and change Add New Group to Add New Monitor Group. The button group can only create expression buttons and has no start/stop image button, how do you like it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants