Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling layer none - Redundant calculation and warning of STD #313

Open
leondavi opened this issue Jul 17, 2024 · 0 comments
Open

Scaling layer none - Redundant calculation and warning of STD #313

leondavi opened this issue Jul 17, 2024 · 0 comments

Comments

@leondavi
Copy link

leondavi commented Jul 17, 2024

The scaling layer none case should move outside the if statement that performs std calculation.

If user selects the "layer none" it means that he already takes care to the scaling process of data, therefore, there is no need to calculate the std nor display a warning message in case std is smaller than numeric limits.

if(scaler == Scaler::NoScaling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant