Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Different highlight colors #46

Open
davidteejay opened this issue Jan 28, 2020 · 3 comments
Open

Different highlight colors #46

davidteejay opened this issue Jan 28, 2020 · 3 comments

Comments

@davidteejay
Copy link

Hi, Nice work so far. This module has really saved me 😄

Is it possible to have a feature where you can specify the color per highlight? This will be very useful if someone wants to have different colors for the highlighted texts.

Thank you.

@guilhermedecampo
Copy link
Member

Hey David! Thanks for the kind words.

It's pretty much possible. You need to do some logic in your side for that.
So you would control how the highlighted excerpt should behave.

@guilhermedecampo
Copy link
Member

If you wanna do it and add it as example on our repo, you're most welcome.

@desaawa
Copy link

desaawa commented Nov 27, 2020

@guilhermedecampo I think the challenge here would be with changing the color of the highlighted text, as some highlight colors might need you the change the text color.

For instance, I'm using yellow, but when i switch to dark mode, I'd like the maintain the yellow highlight but all my text is now white-ish, and I'd like to make the color of the text behind the yellow highlight not-white so that it can work with the yellow background...

Would it be possible to have a prop for the color of the highlighted text?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants