Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveServer.servedocs() creates cast files infinite times. #65

Closed
terasakisatoshi opened this issue Apr 20, 2023 · 3 comments · Fixed by #79
Closed

LiveServer.servedocs() creates cast files infinite times. #65

terasakisatoshi opened this issue Apr 20, 2023 · 3 comments · Fixed by #79

Comments

@terasakisatoshi
Copy link
Member

My workflow includes running LiveServer.servedocs to check that our documentation is created as planned.

It seems LiveServer.servedocs function calls docs/make.jl in the background. Therefore generate_example_page(sections) is called infinite times, which creates all cast files even though they are already in docs/assets.

Adding a conditional branch to check a specified cast file is created is a good idea.

This is my homework.

@hyrodium
Copy link
Collaborator

Should we add an option like overwrite_cast or skip_existing_cast?

@terasakisatoshi
Copy link
Member Author

🤔 Where can i find the option? > skip_existing_cast

@hyrodium
Copy link
Collaborator

Oh, sorry for not being clear enough. I was thinking of adding a keyword argument skip_existing_cast to generate_example_page in docs/make.jl not to regenerate the cast files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants