You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Find a way to determine if the current .gitattributes files has changed so we potentially only have to read it one time per repo, and will be notified if something changes. We could look at using the index and any caches it may have to determine if the file has changed.
The text was updated successfully, but these errors were encountered:
@jgrosso I am interested in your opinion on this. The check.js file reads the .gitattributes each time we check a file. You can imagine this incurs some overhead. An obvious improvement is to avoid this. Not sure how to best cache the filters, though. Needs to change per repo and needs to change when the file changes. I think the check callback gets the repo instance but I need to verify. I know smudge and clean do.
Re: watching .gitattributes for changes, would https://github.com/Axosoft/nsfw work?
Whenever that changes, we could parse out the filters and store them wherever. (Whenever a repo changes, we'd setup a listener on the new .gitattributes file and go from there).
Would this serve our needs, do you think?
Yeah nsfw could work. We will check it out. Not sure the overhead of adding in nsfw. It feels a bit weird for a NodeGit augmentation library to spawn an nsfw instance.
Find a way to determine if the current .gitattributes files has changed so we potentially only have to read it one time per repo, and will be notified if something changes. We could look at using the index and any caches it may have to determine if the file has changed.
The text was updated successfully, but these errors were encountered: