From c6ad3f668ec03edd36c8c26638541e05da334d76 Mon Sep 17 00:00:00 2001
From: Josh Bradley <joshbradley@microsoft.com>
Date: Mon, 27 Jan 2025 01:54:09 -0500
Subject: [PATCH] fix logging of extra metadata

---
 .../application_insights_workflow_callbacks.py  | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/backend/graphrag_app/logger/application_insights_workflow_callbacks.py b/backend/graphrag_app/logger/application_insights_workflow_callbacks.py
index 7fcfab4..5224b2e 100644
--- a/backend/graphrag_app/logger/application_insights_workflow_callbacks.py
+++ b/backend/graphrag_app/logger/application_insights_workflow_callbacks.py
@@ -88,7 +88,7 @@ def _format_details(self, details: Dict[str, Any] | None = None) -> Dict[str, An
         """
         if not isinstance(details, dict) or (details is None):
             return {}
-        return {"custom_dimensions": {**self._properties, **unwrap_dict(details)}}
+        return {**self._properties, **unwrap_dict(details)}
 
     def workflow_start(self, name: str, instance: object) -> None:
         """Execute this callback when a workflow starts."""
@@ -101,10 +101,7 @@ def workflow_start(self, name: str, instance: object) -> None:
             else ""
         )  # will take the form "(1/4)"
         message += f"Workflow{workflow_progress}: {name} started."
-        details = {
-            "workflow_name": name,
-            # "workflow_instance": str(instance),
-        }
+        details = {"workflow_name": name}
         if self._index_name:
             details["index_name"] = self._index_name
         self._logger.info(
@@ -120,10 +117,7 @@ def workflow_end(self, name: str, instance: object) -> None:
             else ""
         )  # will take the form "(1/4)"
         message += f"Workflow{workflow_progress}: {name} complete."
-        details = {
-            "workflow_name": name,
-            # "workflow_instance": str(instance),
-        }
+        details = {"workflow_name": name}
         if self._index_name:
             details["index_name"] = self._index_name
         self._logger.info(
@@ -135,10 +129,9 @@ def error(
         message: str,
         cause: Optional[BaseException] = None,
         stack: Optional[str] = None,
-        details: Optional[dict] = None,
+        details: Optional[dict] = {},
     ) -> None:
         """A call back handler for when an error occurs."""
-        details = {} if details is None else details
         details = {"cause": str(cause), "stack": stack, **details}
         self._logger.error(
             message,
@@ -162,7 +155,7 @@ def log(self, message: str, details: Optional[dict] = None) -> None:
 
 def unwrap_dict(input_dict, parent_key="", sep="_"):
     """
-    Recursively unwraps a nested dictionary by flattening it into a single-level dictionary.
+    Recursively unwrap/flatten a dictionary.
 
     Args:
         input_dict (dict): The input dictionary to be unwrapped.