Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Azure Core v2: check in code generated in compile-time #44401

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Azure Core v2: check in code generated in compile-time #44401

wants to merge 1 commit into from

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Feb 25, 2025 •
edited
Loading

Description

  • 1. Annotation processor should generate code in location that can be checked into the repo
  • 2. It should be possible to easily turn it off once it becomes more mature
  • 3. The precondition is to have a validation as a part of CI pipeline that
  • - compiles code (and overrides auto-generated files)
  • - git diff generated sources
  • - fails if checked in sources are not identical to the auto-generated ones.
  • To ensure that checked in code remains consistent with the one produced by the generator.

Closes: #44380

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 will be requested when the pull request is marked ready for review vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft will be requested when the pull request is marked ready for review alzimmermsft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
clientcore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Core v2: check in code generated in compile-time
1 participant
@samvaity