Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-credential] 1.3.0 package is missing types #31037

Closed
xirzec opened this issue Sep 9, 2024 · 2 comments
Closed

[test-credential] 1.3.0 package is missing types #31037

xirzec opened this issue Sep 9, 2024 · 2 comments
Assignees
Labels
test-utils Label for the issues related to the @azure/test-utils package
Milestone

Comments

@xirzec
Copy link
Member

xirzec commented Sep 9, 2024

@azure-tools/test-credential@1.3.0 on npm doesn't appear to have the types published:

image

This is causing pipeline errors:

image

I think the file name is wrong here:

"types/tools-test-credential.d.ts",

Probably we can just adjust to include the entire types folder, but please verify that the types key is correct

@xirzec xirzec added the test-utils Label for the issues related to the @azure/test-utils package label Sep 9, 2024
@maorleger maorleger self-assigned this Sep 9, 2024
@maorleger
Copy link
Member

Original issue is fixed and test-credential 1.3.1 is released. I want to keep this open to track a longer term prevention that blocks the release if there are no types. @ckairen maybe I can sync up with you and see if there are any "hooks" we can use here to sanity check the published packages?

@maorleger maorleger added this to the 2024-11 milestone Sep 9, 2024
@HarshaNalluru
Copy link
Member

Thanks for handling this @maorleger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-utils Label for the issues related to the @azure/test-utils package
Projects
None yet
Development

No branches or pull requests

3 participants