[tracing] Add support for addEvent #31162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
maorleger
requested review from
bterlson,
a team and
mpodwysocki
as code owners
jeremymeng
reviewed
Sep 19, 2024
mpodwysocki
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-tracing
@azure/opentelemetry-instrumentation-azure-sdk
@typespec/ts-http-runtime
Issues associated with this PR
Resolves #31158
Describe the problem that is addressed by this PR
OpenTelemetry supports adding events to a span, and part of the gen-ai
specification expects events to be added on a span.
This PR adds support for the
addEventAPI in our core-tracing library as wellas our otel-sdk.
Adding a required field is a breaking change, so this is added as optional. The
implementation will need to use the safe-navigation operator syntax or check for
the function's existence before calling it.
In passing, I am updating some of our internal transformations to use OTel's APIs instead.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists