Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure.AI.OpenAI] Add net8.0 target / remove RequiredTargetFrameworks workaround #46891

Open
m-redding opened this issue Oct 29, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI

Comments

@m-redding
Copy link
Member

A net8.0 target is going to be added to RequiredTargetFrameworks in #46637

A workaround was added to Azure.AI.OpenAI because there are a number of blocking issues preventing it from adding a net8.0 target:

The primary issue is that OpenAI has internals visible to Azure.AI.OpenAI. However, OpenAI only has a net6.0 target. There are a couple internal polyfill attributes that are not trimmed from the net6.0 dll, since these attributes are not available in net6.0. Since there is no net8.0 target, the net8.0 target in Azure OpenAI falls back on the net6.0 target.

The following attributes cause compiler failures because these attributes exist in both System.Runtime and OpenAI:

In order for Azure OpenAI to be able to have a net8.0 target, I believe the OpenAI library will need to release with a net8.0 target first. Alternatively, it should work to turn off internals visible to in the OpenAI library. Once that is done the workaround should be removed from Azure.AI.OpenAI.

@m-redding m-redding added Client This issue points to a problem in the data-plane of the library. OpenAI labels Oct 29, 2024
@m-redding
Copy link
Member Author

Created an issue in OpenAI as well for tracking: openai/openai-dotnet#272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Development

No branches or pull requests

1 participant