[Bug] Passing in Throughput Object with offer_throughput

[tvaron3]

The following code snippet does not work. The throughput object currently only works for auto scale. For manual throughput passing in an int is the only option. The logic for parsing the auto scale properties should also be reviewed again.

collection = db_fixture.get_collection(client.get_database_client(DB_NAME), collection_name)

# get current collection throughput settings
current_throughput = collection.get_throughput()
print("Current throughput: ", current_throughput.offer_throughput)

new_throughput = ThroughputProperties(offer_throughput=2500)
update_throughput = collection.replace_throughput(new_throughput)

retrieve_throughput = collection.get_throughput()
assert getattr(retrieve_throughput, "offer_throughput") == getattr(new_throughput, "offer_throughput")

The behavior for the code above should be the same as the one below.

collection = db_fixture.get_collection(client.get_database_client(DB_NAME), collection_name)

# get current collection throughput settings
current_throughput = collection.get_throughput()
print("Current throughput: ", current_throughput.offer_throughput)

new_throughput = ThroughputProperties(offer_throughput=2500)
update_throughput = collection.replace_throughput(new_throughput.offer_throughput)

retrieve_throughput = collection.get_throughput()
assert getattr(retrieve_throughput, "offer_throughput") == getattr(new_throughput, "offer_throughput")

[fredcohen-aa]

azure-sdk-for-python/sdk/cosmos/azure-cosmos/azure/cosmos/_base.py

Line 792 in 230ab94

if throughput.offer_throughput:

def _replace_throughput(
    throughput: Union[int, ThroughputProperties],
    new_throughput_properties: Dict[str, Any]
) -> None:
    if isinstance(throughput, int):
        new_throughput_properties["content"]["offerThroughput"] = throughput
    else:
        try:
            max_throughput = throughput.auto_scale_max_throughput
            increment_percent = throughput.auto_scale_increment_percent
            if max_throughput is not None:
                new_throughput_properties['content']['offerAutopilotSettings']['maxThroughput'] = max_throughput
                if increment_percent:
                    new_throughput_properties['content']['offerAutopilotSettings']['autoUpgradePolicy']['throughputPolicy']['incrementPercent'] = increment_percent  # pylint: disable=line-too-long
                if throughput.offer_throughput:
                    new_throughput_properties["content"]["offerThroughput"] = throughput.offer_throughput
        except AttributeError as e:
            raise TypeError("offer_throughput must be int or an instance of ThroughputProperties") from e

Looking more closely at the code I believe it's line 792 shouldn't be indented under the " if max_throughput is not None" If it were shifted left it could work as intended.

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @AbhinavTrips @bambriz @Pilchie @pjohari-ms @simorenoh.