Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all the types in azure_core to match typespec_client_core #2181

Open
heaths opened this issue Feb 15, 2025 · 2 comments
Open

Refactor all the types in azure_core to match typespec_client_core #2181

heaths opened this issue Feb 15, 2025 · 2 comments
Assignees
Labels
Azure.Core The azure_core crate Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@heaths
Copy link
Member

heaths commented Feb 15, 2025

When refactoring most of the general types into typespec and typespec_client_core, I did my best to keep azure_core looking like it did to avoid an even bigger diff with all the changes to imports in other crates. All those other crates also helped double check my progress. Moving those types around became a lower priority.

After beta.1, I'd like to move those types around to match typespec_client_core. I'm pretty happy with the layout - though, open to suggestions otherwise - and I think re-exporting from azure_core that the emitter uses makes sense. Azure service partners will interface entirely with azure_core - which does and will continue to have some Azure-specific types like pagers and pollers - and it gives us flexibility as well.

This will no doubt require changes in the emitter, but my hope is that few to no type names will need to change - just their module paths.

@heaths heaths added Azure.Core The azure_core crate Client This issue points to a problem in the data-plane of the library. labels Feb 15, 2025
@heaths heaths added this to the 2025-03 milestone Feb 15, 2025
@heaths heaths self-assigned this Feb 15, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Feb 15, 2025
@heaths
Copy link
Member Author

heaths commented Feb 15, 2025

@heaths heaths marked this as a duplicate of #2316 Mar 11, 2025
@heaths
Copy link
Member Author

heaths commented Mar 11, 2025

Need to also move request and response modules up into http directly. Move Pager to azure_core.

@heaths heaths modified the milestones: 2025-03, 2025-04 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core The azure_core crate Client This issue points to a problem in the data-plane of the library.
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant