-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] stage_block
, commit_block_list
for BlobClient
, get_container_properties
for ContainerClient
, ServiceClient
#2273
[Storage] stage_block
, commit_block_list
for BlobClient
, get_container_properties
for ContainerClient
, ServiceClient
#2273
Conversation
sdk/storage/azure_storage_blob/src/models/container_properties.rs
Outdated
Show resolved
Hide resolved
stage_block
, commit_block_list
for BlobClient
, get_container_properties
for ContainerClient
, get_service_properties
for ServiceClient
stage_block
, commit_block_list
for BlobClient
, get_container_properties
for ContainerClient
, ServiceClient
You have some clippy lints to resolve as well. Look at the failed build. It's a good idea to run this locally e.g., |
Interesting, this doesn't manifest locally:
I also largely took that Regardless, I removed the duplicate explicit link and re-ran |
If you look at the command in Azure Pipelines, it will use an explicit toolchain e.g., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the lib.rs
change. We don't want to be exposing all those submodules to clients.
I was trying to check out your branch when I realized you're not working in a fork. Please use forks on GitHub: fork your repo, push your branch to your fork, and open a PR normally. This not only yields in faster pull times, but also makes other workflows easier and is the GitHub way. Using a single shared repo is how Azure Repos operates but isn't the norm. |
This PR introduces the following:
BlobClient
stage_block
commit_block_list
ContainerClient
get_container_properties
ServiceClient
ServiceClient
get_service_properties
This PR also moves to the standardized way to fetch randomized seeded names (
random_string
) and includes a helper utility for test setup.