Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: add label under icons on mobile navbar #40

Closed
Dehelssey opened this issue Jan 1, 2025 · 2 comments
Closed

Accessibility: add label under icons on mobile navbar #40

Dehelssey opened this issue Jan 1, 2025 · 2 comments

Comments

@Dehelssey
Copy link

Accessibility best practices states that navbar items should have a label.

We should at least offer an option to display them. Or, better, an option to hide them but display them by default.

Like #39 i'll submit this to Elk's main repo as well :)
@Dehelssey Dehelssey changed the title Accessibility: add label under icons on navbar Accessibility: add label under icons on mobile navbar Jan 1, 2025
@Dehelssey
Copy link
Author

OK, there's already a MR on upstream repo: elk-zone#3120

@Cl0v1s
Copy link

Cl0v1s commented Jan 3, 2025

Yup, it's more an upstream job

@Cl0v1s Cl0v1s closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cl0v1s @Dehelssey