Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable restart delay #9

Open
cwinkler opened this issue Jan 2, 2024 · 3 comments
Open

Configurable restart delay #9

cwinkler opened this issue Jan 2, 2024 · 3 comments

Comments

@cwinkler
Copy link

cwinkler commented Jan 2, 2024

Hello and Happy new Year!

We are using caddy-supervisor in our Devcontainer Configuration with php-fpm. As we are switching all of our Production Containers to Laravel Octane we would like to switch our Devcontainers to Octane too.

The Problem is that Octane is crashing fairly often while developing because of Parse Errors etc. so the restart delay increases pretty fast.

We would like to be able to configure maxRestartDelay and durationToResetRestartDelay in supervisor.go

If you are OK with this I'd be happy to provide a PR

@francislavoie
Copy link

francislavoie commented Jan 2, 2024

If you're using octane, just switch to using FrankenPHP 😄 It's actually Caddy + PHP in one bundle, lets you get rid of php-fpm.

Then you won't need caddy-supervisor at all, because FrankenPHP takes care of running PHP as a plugin of Caddy.

@cwinkler
Copy link
Author

cwinkler commented Jan 2, 2024

I was aware of FrankenPHP but never thought about using it for Development. Will check it out, thanks!

@Baldinof
Copy link
Owner

Baldinof commented Jan 2, 2024

Hello!

As @francislavoie said, FrankenPHP seems a good solution now.

If you use Octane, you may not need to use caddy directly and should be able to just start octane in your containers.

(if you need it, I would merge a PR that makes these configurable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants