Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to promisify Order instance methods #10

Open
cwilso03 opened this issue Apr 25, 2020 · 1 comment
Open

Need to promisify Order instance methods #10

cwilso03 opened this issue Apr 25, 2020 · 1 comment

Comments

@cwilso03
Copy link

Enhancement request:

Since you have async methods for things like order creation (Order.createAsync()), would also be good to have async versions of the instance methods (getAreaCodes(), getTns(), getNotes(), etc.) on the returned Order object.

I'm guessing the other main API objects also need similar treatment (don't know yet, as I'm working my way through the v1 to v2 conversion process).

@dtolb
Copy link
Contributor

dtolb commented Jun 16, 2020

@cwilso03 We'll look into this and double check. I believe they should be included but perhaps not.

In the meantime you should be able to require('bluebird') and promisify the instance method needed from the object itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants