Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numbers.Order is a function. #11

Open
izakfilmalter opened this issue Jun 4, 2020 · 2 comments
Open

numbers.Order is a function. #11

izakfilmalter opened this issue Jun 4, 2020 · 2 comments

Comments

@izakfilmalter
Copy link

Very curious as to why numbers.Order is an empty function.

Busy making TypeScript types for the lib and reading through the code. Seems like this happen a lot in this lib where the top level item in the api is an empty function. I feel like this probably creates a lot of confusion for users.

function Order(){
}
@dtolb
Copy link
Contributor

dtolb commented Jun 16, 2020

Not the original author here; so I can't comment with 100% certainty. I can only guess it made sense at the time and you're the first to bring up as it's mostly worked since then with minimal confusion.

@izakfilmalter
Copy link
Author

It's just that other top level apis are objects, so was more looking at it from a consistency pov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants