refactored some while loops to neater for loops

Author: Adrian Reimann

day_04/4-1.php

@@ -53,9 +53,8 @@ function markBoard(&$board, $number) {
     }
 
     //after we've replaced all numbers of the board, check the columns (we already checked rows when going per row)
-    $i = 0;
-    while($i < 5) { //loop through columns up to  5 (cannot use count($row) as some rows may have gotten shorter)
-       $column = array_column($board, $i++);
+    for($i = 0; $i < 5; $i++) { //loop through columns up to  5 (cannot use count($row) as some rows may have gotten shorter)
+       $column = array_column($board, $i);
         if(array_sum($column) == 0) {
             return true; //winner by column!
         }

day_04/4-2.php

@@ -62,9 +62,8 @@ function markBoard(&$board, $number) {
     }
 
     //after we've replaced all numbers of the board, check the columns (we already checked rows when going per row)
-    $i = 0;
-    while($i < 5) { //loop through columns up to  5 (cannot use count($row) as some rows may have gotten shorter)
-       $column = array_column($board, $i++);
+    for($i = 0; $i < 5; $i++) { //loop through columns up to  5 (cannot use count($row) as some rows may have gotten shorter)
+       $column = array_column($board, $i);
         if(array_sum($column) == 0) {
             return true; //winner by column!
         }

day_13/13-2.php

@@ -171,17 +171,14 @@ function fillEmptyFields($arr, $filler = '.') {
     }
 
     //fill every row of the array with the "empty" filler
-    $i = 0;
     $full_arr = [];
-    while($i <= $highest_y) { //<= as we start from 0
+    for($i = 0; $i <= $highest_y ; $i++) { //<= as we start from 0
         $full_arr[$i] = array_fill(0 , $highest_x+1, $filler); //dot will be our "empty" fields (highest_x+1 as we start from 0)
 
         //if this row exists on the array of actual values, here is the time where we replace the "empty" fields of that row with actual fields
         if(isset($arr[$i])) {
             $full_arr[$i] = array_replace($full_arr[$i], $arr[$i]);
         }
-
-        $i++;
     }
 
     //return the filled up array