Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File loading is not VS Code Remote compliant #61

Open
PEZ opened this issue May 15, 2022 · 3 comments
Open

File loading is not VS Code Remote compliant #61

PEZ opened this issue May 15, 2022 · 3 comments

Comments

@PEZ
Copy link
Collaborator

PEZ commented May 15, 2022

In #38 it is brought up that when loading files we read them us the node fs module, which we can't do if Joyride should work in remote scenarios (which are plenty and very common).

Here's where it happens:

(fs/readFileSync

@borkdude
Copy link
Collaborator

If we need to load files asynchronously, then we need to rewrite to the SCI async API, which is not yet finished. So I think I'll take this as an opportunity to improve that while working on this if you don't mind.

@PEZ
Copy link
Collaborator Author

PEZ commented May 15, 2022

Sounds excellent! Will that bring us closer to nbb-style top-level await?

@borkdude
Copy link
Collaborator

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants