Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] rom=<url> parameter in https://binbashbanana.github.io/webretro/?core=handy #117

Open
Fabrizio-Caruso opened this issue Oct 31, 2024 · 3 comments

Comments

@Fabrizio-Caruso
Copy link

Fabrizio-Caruso commented Oct 31, 2024

I would like to use your JS port of the handy emulator at https://binbashbanana.github.io/webretro/?core=handy to let people try my 9 home-brew games (which I can build for a multitude of targets) as I already do for some machines through JS emulators (see my games on the browser at https://github.com/Fabrizio-Caruso/CROSS-LIB/blob/master/docs/GAMES.md#trex)

If I try to load my games with your handy core with

https://binbashbanana.github.io/webretro/?core=handy&rom=https://github.com/Fabrizio-Caruso/CROSS-LIB/releases/download/AtarLynxVersions/Xstinger_atari_lynx.lnx

I get this error about not founding the rom:

image

I have also tried to use http for the location of my roms.
Your emulator may have an issue with redirection.
It is a pity because GitHub repository is a nice and free place to keep binaries.

If this appears technically complex, we can look at how the other JS emulators manage to load roms from GitHub.

For example:
https://nippur72.github.io/vic20-emu/?joy=1&load=http://github.com/Fabrizio-Caruso/CROSS-LIB/releases/download/stinger/Xstinger_vic20_exp_16k.prg

https://js99er.net/#/?cartUrl=https:%2F%2Fgithub.com%2FFabrizio-Caruso%2FCROSS-LIB%2Freleases%2Fdownload%2Fti99_1.32%2FXstingerti.bin

https://webmsx.org/?cartridge1_url=http://github.com/Fabrizio-Caruso/CROSS-LIB/releases/download/shuriken/Xshuriken_msx_16k.rom

https://nippur72.github.io/laser500emu/?load=http://github.com/Fabrizio-Caruso/CROSS-LIB/releases/download/verbix/Xverbix_laser500.bin

@ethanaobrien
Copy link

ethanaobrien commented Nov 1, 2024

This is not a bug.

image

https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS

If this appears technically complex, we can look at how the other JS emulators manage to load roms from GitHub.

They appear to use a php page as a proxy, which is not possible with how this project is hosted

@Fabrizio-Caruso
Copy link
Author

Fabrizio-Caruso commented Nov 1, 2024

@ethanaobrien I see it is blocked. Do all other emulators rely on PHP? If you won't or can't implement this for technical or other reasons, is there a way I can use your emulators with GitHub repositories? Do I have to host them elsewhere?

@Fabrizio-Caruso
Copy link
Author

@nippur72 how is your emulator circumventing GitHub? I don't remember you telling me you were using a php proxy. I thought it was pure Javascript. I may not remember well.

@Fabrizio-Caruso Fabrizio-Caruso changed the title [bug] rom=<url> parameter in https://binbashbanana.github.io/webretro/?core=handy [feature request] rom=<url> parameter in https://binbashbanana.github.io/webretro/?core=handy Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants