Skip to content

Commit 569c281

Browse files
authored
Merge pull request #90 from BitOne/GITHUB-88_php73_compatibility
GITHUB-88 Adds PHP 7.3 Compatibility
2 parents 4dd851a + f84d859 commit 569c281

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ php:
88
- 7.0
99
- 7.1
1010
- 7.2
11+
- 7.3
1112
- nightly
1213

1314
matrix:

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ One of the main source of inspiration for this tool is the Java jmap tool with t
1010

1111
Compatibility
1212
-------------
13-
PHP 5.5, 5.6, 7.0, 7.1, and 7.2.
13+
PHP 5.5, 5.6, 7.0, 7.1, 7.2 and 7.3.
1414

1515
May compiles and works with PHP 5.3 and 5.4 but hasn't been tested with these versions.
1616

extension/php7/tests/dump-array.phpt

+10-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,16 @@ Check array dump from memory
3939

4040
foreach ($myArrayDump['children'] as $key => $child) {
4141
echo " Key: ".$key."\n";
42-
echo " Type:".$meminfoData['items'][$child]['type']."\n";
42+
echo " Type:";
43+
$type = $meminfoData['items'][$child]['type'];
44+
if ('int' === $type) {
45+
echo "integer";
46+
} elseif ('bool' === $type) {
47+
echo "boolean";
48+
} else {
49+
echo $type;
50+
}
51+
echo "\n";
4352
echo " Is root:".$meminfoData['items'][$child]['is_root']."\n";
4453
}
4554
?>

extension/php7/tests/dump-scalar.phpt

+9-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,15 @@ Check scalar dump from memory
5353
foreach ($scalars as $scalar) {
5454
echo "Symbol: ".$scalar['symbol_name']."\n";
5555
echo " Frame: ".$scalar['frame']."\n";
56-
echo " Type: ".$scalar['type']."\n";
56+
echo " Type: ";
57+
if ('int' === $scalar['type']) {
58+
echo "integer";
59+
} elseif ('bool' === $scalar['type']) {
60+
echo "boolean";
61+
} else {
62+
echo $scalar['type'];
63+
}
64+
echo "\n";
5765
echo " Is root: ".$scalar['is_root']."\n";
5866
}
5967
?>

0 commit comments

Comments
 (0)