Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Wayland support in Workspaces applet #470

Open
JoshStrobl opened this issue Oct 9, 2023 · 1 comment · Fixed by #485 · May be fixed by #674
Open

Implement Wayland support in Workspaces applet #470

JoshStrobl opened this issue Oct 9, 2023 · 1 comment · Fixed by #485 · May be fixed by #674
Assignees
Labels
wayland Tasks related to port to Wayland
Milestone

Comments

@JoshStrobl
Copy link
Member

This is a meta-tasklist for implementation of Wayland support in Workspace Applet, such as via use of libxfce4windowing. Strict usage of Wnck is not viable as that is limited to X11. libxfce4windowing is designed to support both X11 and Wayland.

@JoshStrobl JoshStrobl added the wayland Tasks related to port to Wayland label Oct 9, 2023
@JoshStrobl JoshStrobl self-assigned this Oct 9, 2023
@JoshStrobl JoshStrobl moved this to Todo in Budgie 10 Oct 9, 2023
@JoshStrobl JoshStrobl removed their assignment Oct 9, 2023
@JoshStrobl JoshStrobl changed the title Implement Wayland support in Workspace Applet Implement Wayland support in Workspaces Applet Oct 9, 2023
@JoshStrobl JoshStrobl changed the title Implement Wayland support in Workspaces Applet Implement Wayland support in Workspaces applet Oct 9, 2023
@JoshStrobl JoshStrobl moved this from Todo to In Progress in Budgie 10 Oct 22, 2023
@JoshStrobl JoshStrobl self-assigned this Oct 22, 2023
@JoshStrobl JoshStrobl added this to the 10.9 milestone Oct 22, 2023
JoshStrobl added a commit that referenced this issue Oct 27, 2023
JoshStrobl added a commit that referenced this issue Oct 29, 2023
…ndowing (#485)

* Port TabSwitcher over to libxfce4windowing

This PR ports our TabSwitcher over to libxfce4windowing from using libwnck directly. To facilitate this, considerable amounts of the code was gutted or rewritten, for example wm no longer does any sort of cur_tabs tracking. That is left up to TabSwitcher.

Instead of rebuilding tabswitcher contents every single time we invoke it, we allow it to handle its own state and handle changes based on libxfce4windowing events. Windows are added / removed automatically, workspace handling is done to support show-all-windows function and workspace swapping, and we leverage sort with our recency list and filter to know when to hide items.

* ci: change package name for libxfce4windowing devel

* Port Show Desktop applet to libxfce4windowing

Fixes #471

* Port Workspace applet

Fixes #470

* Fix typo in signal

Co-authored-by: Evan Maddock <[email protected]>

* Use construct on TabSwitcherWindow

Co-authored-by: Evan Maddock <[email protected]>

* Remove unnecessary workspace switch code.

Use warning and document backwards / forwards logic.

* Make TabSwitcherSwitch sub-class Gtk.FlowBoxChild

* Clean up bit mask checking

Co-authored-by: Evan Maddock <[email protected]>

* Use down var already defined

Co-authored-by: Evan Maddock <[email protected]>

* Cleanup extra newline

Co-authored-by: Evan Maddock <[email protected]>

---------

Co-authored-by: Evan Maddock <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Budgie 10 Oct 29, 2023
@JoshStrobl
Copy link
Member Author

Still some work to be done on this front since it uses xid.

@JoshStrobl JoshStrobl reopened this Jan 4, 2025
@JoshStrobl JoshStrobl moved this from Done to In Progress in Budgie 10 Jan 4, 2025
@JoshStrobl JoshStrobl modified the milestones: 10.9, 10.10 Jan 4, 2025
@EbonJaeger EbonJaeger self-assigned this Jan 4, 2025
@EbonJaeger EbonJaeger linked a pull request Feb 12, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wayland Tasks related to port to Wayland
Projects
Status: In Progress
2 participants