Skip to content

Commit 4475156

Browse files
author
Carlos Jaramillo
committed
Added param for verbosity on the image proc (warping) and added the respective arguments to the ccny_openni_launchers
1 parent a662875 commit 4475156

File tree

9 files changed

+51
-22
lines changed

9 files changed

+51
-22
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,4 @@ lib
3333
msg_gen
3434
srv_gen
3535
src/*/cfg
36+
warp.yml

ccny_openni_launch/launch/include/device.launch

+1
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,4 @@
3535
</node>
3636

3737
</launch>
38+

ccny_openni_launch/launch/include/play.launch

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22
<launch>
33

44
<arg name="bag_name" />
5+
<arg name="bag_rate" default="1.0" />
6+
<arg name="bag_start" default="0.0" />
57

68
<node pkg="rosbag" type="play" name="play" output="screen"
7-
args="$(arg bag_name) --clock --start=0.0 --queue=1000 --rate=1.0"/>
9+
args="$(arg bag_name) --clock --start=$(arg bag_start) --queue=1000 --rate=$(arg bag_rate)"/>
810

9-
</launch>
11+
</launch>

ccny_openni_launch/launch/include/proc.launch

+8-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33

44
<arg name="manager_name" />
55
<arg name="calib_path" />
6-
<arg name="publish_cloud" default="false"/>
6+
<arg name="publish_cloud" />
7+
<arg name="scale" />
8+
<arg name="unwarp" />
9+
<arg name="verbose" />
710

811
<!-- Debayered images -->
912
<node pkg="nodelet" type="nodelet" name="debayer"
@@ -14,13 +17,14 @@
1417

1518
<node pkg="nodelet" type="nodelet" name="rgbd_image_proc"
1619
args="load ccny_rgbd/RGBDImageProcNodelet $(arg manager_name)"
17-
output="screen">
20+
output="log">
1821

1922
<!-- Resample by a factor of 2-->
20-
<param name="scale" value="1.0"/>
21-
<param name="unwarp" value="true"/>
23+
<param name="scale" value="$(arg scale)"/>
24+
<param name="unwarp" value="$(arg unwarp)"/>
2225
<param name="publish_cloud" value="$(arg publish_cloud)"/>
2326
<param name="calib_path" value="$(arg calib_path)"/>
27+
<param name="verbose" value="$(arg verbose)"/>
2428

2529
</node>
2630

ccny_openni_launch/launch/openni.launch

+10-4
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
<launch>
33

44
<!-- Parameters -->
5-
<arg name="manager_name" value="rgbd_manager"/>
5+
<arg name="manager_name" default="rgbd_manager"/>
66
<arg name="calib_path" default="$(find ccny_rgbd)/data/calibration_openni_default"/>
7-
<arg name="publish_cloud" default="false"/>
7+
<arg name="unwarp" default="false"/>
8+
<arg name="scale" default="1.0"/>
9+
<arg name="publish_cloud" default="true"/>
10+
<arg name="verbose" default="false"/> # to display rgbd_image_proc messages
811
<arg name="image_mode" default="2" />
912
<arg name="depth_mode" default="2"/>
1013
# modes:
@@ -28,7 +31,10 @@
2831
<include file="$(find ccny_openni_launch)/launch/include/proc.launch">
2932
<arg name="manager_name" value="$(arg manager_name)" />
3033
<arg name="calib_path" value="$(arg calib_path)" />
31-
<arg name="publish_cloud" value="$(arg publish_cloud)" />
34+
<arg name="unwarp" value="$(arg unwarp)" />
35+
<arg name="scale" value="$(arg scale)" />
36+
<arg name="publish_cloud" value="$(arg publish_cloud)" />
37+
<arg name="verbose" value="$(arg verbose)"/>
3238
</include>
3339

34-
</launch>
40+
</launch>

ccny_openni_launch/launch/openni_play.launch

+13-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,15 @@
55

66
<!-- Parameters -->
77
<arg name="bag_name" />
8-
<arg name="manager_name" value="rgbd_manager"/>
9-
<arg name="calib_path" default="$(find ccny_rgbd)/data/calibration_asus_xtion_pro"/>
8+
<arg name="bag_rate" default="1.0" />
9+
<arg name="bag_start" default="0.0" />
10+
11+
<arg name="manager_name" default="rgbd_manager"/>
12+
<arg name="calib_path" default="$(find ccny_rgbd)/data/calibration_openni_default"/>
13+
<arg name="unwarp" default="false"/>
14+
<arg name="scale" default="1.0"/>
1015
<arg name="publish_cloud" default="false"/>
16+
<arg name="verbose" default="false"/> # for rgbd_image_proc messages
1117

1218
<!-- Nodelet manager -->
1319
<node pkg="nodelet" type="nodelet" name="$(arg manager_name)" args="manager"
@@ -16,13 +22,18 @@
1622
<!-- RGBD playback -->
1723
<include file="$(find ccny_openni_launch)/launch/include/play.launch">
1824
<arg name="bag_name" value="$(arg bag_name)" />
25+
<arg name="bag_rate" value="$(arg bag_rate)" />
26+
<arg name="bag_start" value="$(arg bag_start)" />
1927
</include>
2028

2129
<!-- RGBD processing -->
2230
<include file="$(find ccny_openni_launch)/launch/include/proc.launch">
2331
<arg name="manager_name" value="$(arg manager_name)" />
2432
<arg name="calib_path" value="$(arg calib_path)" />
33+
<arg name="unwarp" value="$(arg unwarp)" />
34+
<arg name="scale" value="$(arg scale)" />
2535
<arg name="publish_cloud" value="$(arg publish_cloud)" />
36+
<arg name="verbose" value="$(arg verbose)"/>
2637
</include>
2738

2839
</launch>

ccny_openni_launch/launch/openni_record.launch

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
<!-- Parameters -->
55
<arg name="bag_name" />
6-
<arg name="manager_name" value="rgbd_manager"/>
7-
<arg name="calib_path" default="$(find ccny_rgbd)/data/calibration_asus_xtion_pro"/>
6+
<arg name="manager_name" default="rgbd_manager"/>
7+
<arg name="calib_path" default="$(find ccny_rgbd)/data/calibration_openni_default"/>
88

99
<arg name="image_mode" default="2" />
1010
<arg name="depth_mode" default="2"/>
@@ -30,4 +30,4 @@
3030
<arg name="bag_name" value="$(arg bag_name)" />
3131
</include>
3232

33-
</launch>
33+
</launch>

ccny_rgbd/include/ccny_rgbd/apps/rgbd_image_proc.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,9 @@ class RGBDImageProc
112112
int queue_size_; ///< ROS subscriber (and publisher) queue size parameter
113113

114114
std::string calib_path_; ///< Path to folder where calibration files are stored
115-
bool unwarp_; ///< Whetehr to perform depth unwarping based on polynomial model
116-
bool publish_cloud_; ///< Whetehr to calculate and publish the dense PointCloud
115+
bool verbose_; ///< Whether to print the rectification and unwarping messages
116+
bool unwarp_; ///< Whether to perform depth unwarping based on polynomial model
117+
bool publish_cloud_; ///< Whether to calculate and publish the dense PointCloud
117118

118119
/** @brief Downasampling scale (0, 1]. For example,
119120
* 2.0 will result in an output image half the size of the input

ccny_rgbd/src/apps/rgbd_image_proc.cpp

+8-5
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ RGBDImageProc::RGBDImageProc(
4141
scale_ = 1.0;
4242
if (!nh_private_.getParam("unwarp", unwarp_))
4343
unwarp_ = true;
44+
if (!nh_private_.getParam("verbose", verbose_))
45+
verbose_ = false;
4446
if (!nh_private_.getParam("publish_cloud", publish_cloud_))
4547
publish_cloud_ = true;
4648
if (!nh_private_.getParam("calib_path", calib_path_))
@@ -318,11 +320,12 @@ void RGBDImageProc::RGBDCallback(
318320
// **** print diagnostics
319321

320322
double dur_total = dur_rectify + dur_reproject + dur_unwarp + dur_cloud + dur_allocate;
321-
322-
ROS_INFO("Rect %.1f Reproj %.1f Unwarp %.1f Cloud %.1f Alloc %.1f Total %.1f ms",
323-
dur_rectify, dur_reproject, dur_unwarp, dur_cloud, dur_allocate,
324-
dur_total);
325-
323+
if(verbose_)
324+
{
325+
ROS_INFO("Rect %.1f Reproj %.1f Unwarp %.1f Cloud %.1f Alloc %.1f Total %.1f ms",
326+
dur_rectify, dur_reproject, dur_unwarp, dur_cloud, dur_allocate,
327+
dur_total);
328+
}
326329
// **** publish
327330
rgb_publisher_.publish(rgb_out_msg);
328331
depth_publisher_.publish(depth_out_msg);

0 commit comments

Comments
 (0)