BGL - add CGAL::shortest_path(vs, vt, mesh)
#8724
Draft
+262
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
reviewed
Feb 4, 2025
|
Compilation error here |
MaelRL
added
Not yet approved
What error ? |
afabri
reviewed
Feb 11, 2025
|
|
||
| /*! | ||
| * \ingroup PkgBGLTraversal | ||
| * Computes the shortest path between two vertices in a graph `g` |
There was a problem hiding this comment.
We have to add that the vertices must be in the same connected component
afabri
reviewed
Feb 11, 2025
| for (auto path_it = path.begin(); path_it != path.end() - 1; ++path_it) | ||
| { | ||
| const std::pair<halfedge_descriptor, bool> | ||
| h = halfedge((path_it + 1)->vertex, path_it->vertex, g); |
There was a problem hiding this comment.
Can't we obtain directly the halfedges when running Dijkstra, instead of having a sequence of vertices?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
computes the shortest path between two vertices, using Dijkstra algorithm
Todo
Release Management