Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

** not sure if a bug ** 1 Hour gap in graphs for daylight savings time change. #5898

Closed
dallenk opened this issue Nov 4, 2024 · 19 comments
Closed
Labels
bug Undesired behaviour outdated No recent activity unverified Some days we don't have a clue

Comments

@dallenk
Copy link
Contributor

dallenk commented Nov 4, 2024

I noticed my time change wasn't dealt with very gracefully.

image

I don't remember seeing this before.. perhaps just a *nix issue on my end? did anyone else see this over the weekend?

@dallenk dallenk added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 4, 2024
@dallenk dallenk changed the title ** not sure if a bug ** ** not sure if a bug ** 1 Hour gap in graphs for daylight savings time change. Nov 4, 2024
@TheWitness
Copy link
Member

It's been a problem like forever. I thought I had it resolved at one point, but alas not. It's not that it can not be fixed, but rather that, I can only test once a year ;)

@dallenk
Copy link
Contributor Author

dallenk commented Nov 4, 2024

I can set up a sandbox that changes DST time every 2 hours if you would like lol.

@TheWitness
Copy link
Member

That would be great.

@dallenk
Copy link
Contributor Author

dallenk commented Nov 5, 2024

OK, i'll spin up a sandbox vhost and send you credentials, do you need shell or is web access enough?

@TheWitness
Copy link
Member

Plus sudo.

@dallenk
Copy link
Contributor Author

dallenk commented Nov 5, 2024

No problem.

@dallenk
Copy link
Contributor Author

dallenk commented Nov 5, 2024

Almost done, installed, just adding dependencies..

cliff notes: you'll have a full VM with sudo to do with as you please.

@dallenk
Copy link
Contributor Author

dallenk commented Nov 6, 2024

Almost done but i just f'd up the .bash_profile, Cacti is installed and on the cron poller unless you need spine?

@dallenk
Copy link
Contributor Author

dallenk commented Nov 7, 2024

done.. installed, SSL'd and daylight savings toggles every two hours with systemctl
just have to get you credentials and open up to your IP if you have a static.

@TheWitness
Copy link
Member

Send details to thewitness at cacti dot net. I'm not sure when I'll be able to focus on this. Finishing up a major Cacti project at the moment.

@dallenk
Copy link
Contributor Author

dallenk commented Nov 7, 2024

no problem at all, I'll just turn it into a test system to be broken and restored easily. Share with the rest of your trusted dev's if you want. I can't contribute to code, but I can help with hosting and resources whenever possible.

@TheWitness
Copy link
Member

@dallenk, Maybe Monday I can spend time. I did a cursory code review and could not find the issue. It'll have to be done the way you set it up.

@dallenk
Copy link
Contributor Author

dallenk commented Dec 1, 2024

No problem. It's still running, but I'll admit it's not reproducing that same as it did before.

@TheWitness
Copy link
Member

What RRDtool version are you using? What is it set to from Console > Configuration > Settings > General?

@dallenk
Copy link
Contributor Author

dallenk commented Dec 2, 2024

sorry for the delay, was super busy and our city Christmas parade. Also emailed credentials and IP info to you.

RRDtool 1.7.2
and strangely, i just pulled latest code and how getting RRD errors and no graphs updating anymore. Errors only show when viewing graph, the poller runs just fine without errors.

Log [Total Lines: 856 - Admin view - Unfiltered]
2024-12-02 02:57:48 - SQL Backtrace: (/graph_json.php[277]:rrdtool_function_graph(), /lib/rrd.php[1648]:db_fetch_assoc_prepared(), /lib/database.php[909]:db_execute_prepared())
2024-12-02 02:57:48 - CMDPHP ERROR: A DB Row Failed!, Error: Unknown column 'gti.legend' in 'field list'
2024-12-02 02:57:48 - RRDTOOL WARNING: RRDtool failed after 5 attempts for the following command graphv - --imgformat=SVG --start='1733021821' --end='1733108221' --pango-markup --title='Local Linux Machine - Logged in Users' --vertical-label='users' --slope-mode --base=1000 --height=200 --width=700 --tabwidth '40' --rigid --alt-autoscale-max --lower-limit='0' COMMENT:"From 2024-12-01 02\:57\:01 To 2024-12-02 02\:57\:01\c" COMMENT:" \n" --color BACK#F3F3F3 --color CANVAS#FDFDFD --color SHADEA#CBCBCB --color SHADEB#999999 --color FONT#000000 --color AXIS#2C4D43 --color ARROW#2C4D43 --color FRAME#2C4D43 --border 1 --font TITLE:11:'Arial' --font AXIS:8:'Arial' --font LEGEND:8:'Courier' --font UNIT:8:'Arial' --font WATERMARK:6:'Arial' --slope-mode --watermark 'Generated by Cacti®' .
2024-12-02 02:57:48 - RRDTOOL Error Backtrace: (/graph_json.php[168]:rrdtool_function_graph(), /lib/rrd.php[2766]:rrdtool_execute(), /lib/rrd.php[284]:__rrd_execute(), /lib/rrd.php[444]:cacti_debug_backtrace())

ran upgrade_database as well. no change.

cactidst@cactidstdev:/var/www/cacti$ sudo -u www-data php cli/upgrade_database.php
[sudo] password for cactidst:
NOTE: Repairing Tables for Local Database
ERROR: Your Cacti is already up to date
  - from: v1.3.0
      to: v1.3.0 - Dev 10f28874 @ 2024-12-02 01:43

first time I've seen rrdtool errors before.

@TheWitness
Copy link
Member

When you run the upgrade script, allways use --forcever=version--. So for example, if you are testing on 1.3.0, then always run this after every fresh pull.

php -q upgrade_database.php --forcever=1.2.29

Here is what you should get, all ++ signs

[root@vmhost3 cli]# php -q upgrade_database.php --forcever=1.2.29
NOTE: Repairing Tables for Local Database
Upgrading from v1.2.29
Performing Database Upgrade
  - from v1.2.29 (DB 1.3.0)
      to v1.3.0
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

@TheWitness
Copy link
Member

TheWitness commented Dec 2, 2024

Doing quite a few table changes. Upgrade to the latest RRDtool from the develop branch in GitHub (1.9.1) and you get amazing hover support on the Graphs, and now built-in Gradient support.

image

@dallenk
Copy link
Contributor Author

dallenk commented Dec 2, 2024

that looks amazing!

ahhhh, yea I completely forgot about forcever! sigh.. I need to read more.

that did it.

NOTE: Repairing Tables for Local Database
Upgrading from v1.2.29
Performing Database Upgrade

  • from v1.2.29 (DB 1.3.0)
    to v1.3.0
    ++++++++++++++++++++++++++++++++++++++++++cactidst@cactidstdev:/var/www/cacti/cli$

Copy link

github-actions bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the outdated No recent activity label Feb 1, 2025
@github-actions github-actions bot closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour outdated No recent activity unverified Some days we don't have a clue
Projects
None yet
Development

No branches or pull requests

2 participants