Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEED TO BE IMPROVED!!! #120

Open
edshkliaruk opened this issue Feb 1, 2025 · 1 comment
Open

NEED TO BE IMPROVED!!! #120

edshkliaruk opened this issue Feb 1, 2025 · 1 comment

Comments

@edshkliaruk
Copy link

edshkliaruk commented Feb 1, 2025 •
edited
Loading

All points are related to WEB plugin.

  1. I suggest to define redirectUrl param for AppleProviderOptions interface as you already have implementation inside the plugin.
  2. Also it will be great to define the same redirectUrl param for GoogleLoginOptions and declare in options.

Let window.location.href be as default value, but I would change this a little bit and pass window.location.origin instead of current one. Because a website can have Login on each page and to define each URI on Google Cloud Console it's crazy.

The current implementation causes easily redirect_missmarch_uri issues for Apple and Google auth.
@riderx
Copy link
Contributor

riderx commented Feb 2, 2025

We are open to PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riderx @edshkliaruk