Skip to content

Commit 0251de1

Browse files
authoredDec 12, 2017
Merge pull request ibmruntimes#16 from groeges/jdk8-issue8-diag-jars
Put dtfj, dtfjview and traceformat classes in tools.jar
2 parents 6b0c5ba + 441fffd commit 0251de1

File tree

4 files changed

+32
-51
lines changed

4 files changed

+32
-51
lines changed
 

‎jdk/make/CompileLaunchers.gmk

+6-3
Original file line numberDiff line numberDiff line change
@@ -414,16 +414,19 @@ $(eval $(call SetupLauncher,jcmd, \
414414
# Include executables for OpenJ9 (jdmpview, traceformat and jextract)
415415
$(eval $(call SetupLauncher,jdmpview, \
416416
-DEXPAND_CLASSPATH_WILDCARDS \
417-
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.dtfjview.DTFJView"$(COMMA) }'))
417+
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.dtfjview.DTFJView"$(COMMA) }' \
418+
-DAPP_CLASSPATH='{ "/lib/tools.jar"$(COMMA) "/classes" }'))
418419

419420
$(eval $(call SetupLauncher,traceformat, \
420421
-DEXPAND_CLASSPATH_WILDCARDS \
421-
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.format.TraceFormat"$(COMMA) }'))
422+
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.format.TraceFormat"$(COMMA) }' \
423+
-DAPP_CLASSPATH='{ "/lib/tools.jar"$(COMMA) "/classes" }'))
422424

423425
ifneq ($(findstring $(OPENJDK_TARGET_OS),linux aix),)
424426
$(eval $(call SetupLauncher,jextract, \
425427
-DEXPAND_CLASSPATH_WILDCARDS \
426-
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.j9.dump.extract.Main"$(COMMA) }'))
428+
-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.ibm.jvm.j9.dump.extract.Main"$(COMMA) }' \
429+
-DAPP_CLASSPATH='{ "/lib/tools.jar"$(COMMA) "/classes" }'))
427430
endif
428431

429432
ifeq ($(OPENJDK_TARGET_OS), windows)

‎jdk/make/CreateJars.gmk

+22-44
Original file line numberDiff line numberDiff line change
@@ -56,47 +56,6 @@ $(eval $(call MakeDir, $(IMAGES_OUTPUTDIR)/lib))
5656

5757
##########################################################################################
5858

59-
$(eval $(call SetupArchive,BUILD_DTFJ_JAR, , \
60-
SRCS := $(JDK_OUTPUTDIR)/classes, \
61-
INCLUDES := com/ibm/dtfj com/ibm/jvm/j9/dump com/ibm/java/diagnostics/utils, \
62-
JAR := $(IMAGES_OUTPUTDIR)/lib/ext/dtfj.jar, \
63-
SKIP_METAINF := true))
64-
65-
66-
##########################################################################################
67-
68-
$(eval $(call SetupArchive,BUILD_DTFJVIEW_JAR, , \
69-
SRCS := $(JDK_OUTPUTDIR)/classes, \
70-
INCLUDES := com/ibm/jvm/dtfjview, \
71-
JAR := $(IMAGES_OUTPUTDIR)/lib/ext/dtfjview.jar, \
72-
SKIP_METAINF := true))
73-
74-
75-
##########################################################################################
76-
77-
$(eval $(call SetupArchive,BUILD_TRACEFORMAT_JAR, , \
78-
SRCS := $(JDK_OUTPUTDIR)/classes, \
79-
INCLUDES := com/ibm/jvm/traceformat \
80-
com/ibm/jvm/format \
81-
com/ibm/jvm/trace, \
82-
EXTRA_FILES := com/ibm/jvm/Debug.class \
83-
com/ibm/jvm/FormatTimestamp.class \
84-
com/ibm/jvm/Indent.class \
85-
com/ibm/jvm/InputFile.class \
86-
com/ibm/jvm/MessageFile.class \
87-
com/ibm/jvm/OutputFile.class \
88-
com/ibm/jvm/ProgramOption.class \
89-
com/ibm/jvm/Statistics.class \
90-
com/ibm/jvm/Summary.class \
91-
com/ibm/jvm/Threads.class \
92-
com/ibm/jvm/Timezone.class \
93-
com/ibm/jvm/TraceFormat.class \
94-
com/ibm/jvm/Verbose.class, \
95-
JAR := $(IMAGES_OUTPUTDIR)/lib/ext/traceformat.jar, \
96-
SKIP_METAINF := true))
97-
98-
##########################################################################################
99-
10059
$(eval $(call SetupArchive,BUILD_JCONSOLE_JAR, , \
10160
SRCS := $(JDK_OUTPUTDIR)/classes, \
10261
SUFFIXES := .class .gif .png .properties, \
@@ -574,8 +533,14 @@ TOOLS_JAR_INCLUDES := \
574533
sun/tools/serialver \
575534
sun/tools/tree \
576535
sun/tools/util \
577-
com/ibm/tools/attach/attacher
578-
536+
com/ibm/tools/attach/attacher \
537+
com/ibm/jvm/traceformat \
538+
com/ibm/jvm/format \
539+
com/ibm/jvm/trace \
540+
com/ibm/jvm/dtfjview \
541+
com/ibm/dtfj \
542+
com/ibm/jvm/j9/dump \
543+
com/ibm/java/diagnostics/utils
579544

580545
# The sjavac tools is not ready for public consumption.
581546
TOOLS_JAR_EXCLUDES = com/sun/tools/sjavac
@@ -590,7 +555,20 @@ $(eval $(call SetupArchive,BUILD_TOOLS_JAR, , \
590555
META-INF/services/com.sun.jdi.connect.spi.TransportService \
591556
META-INF/services/com.sun.tools.attach.spi.AttachProvider \
592557
META-INF/services/com.sun.tools.internal.ws.wscompile.Plugin \
593-
META-INF/services/com.sun.tools.internal.xjc.Plugin, \
558+
META-INF/services/com.sun.tools.internal.xjc.Plugin \
559+
com/ibm/jvm/Debug.class \
560+
com/ibm/jvm/FormatTimestamp.class \
561+
com/ibm/jvm/Indent.class \
562+
com/ibm/jvm/InputFile.class \
563+
com/ibm/jvm/MessageFile.class \
564+
com/ibm/jvm/OutputFile.class \
565+
com/ibm/jvm/ProgramOption.class \
566+
com/ibm/jvm/Statistics.class \
567+
com/ibm/jvm/Summary.class \
568+
com/ibm/jvm/Threads.class \
569+
com/ibm/jvm/Timezone.class \
570+
com/ibm/jvm/TraceFormat.class \
571+
com/ibm/jvm/Verbose.class, \
594572
JAR := $(IMAGES_OUTPUTDIR)/lib/tools.jar, \
595573
SKIP_METAINF := true, \
596574
CHECK_COMPRESS_JAR := true))

‎jdk/make/Images.gmk

+4-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,10 @@ ifeq ($(PROFILE), )
125125
wsimport$(EXE_SUFFIX) \
126126
schemagen$(EXE_SUFFIX) \
127127
jsadebugd$(EXE_SUFFIX) \
128-
jhat$(EXE_SUFFIX)
128+
jhat$(EXE_SUFFIX) \
129+
jextract$(EXE_SUFFIX) \
130+
jdmpview$(EXE_SUFFIX) \
131+
traceformat$(EXE_SUFFIX)
129132
endif
130133

131134
WINDOWS_JDK_BIN_FILES = \

‎jdk/make/Profiles.gmk

-3
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ ALL_JARS := $(FULL_JRE_JARS) \
8989
$(IMAGES_OUTPUTDIR)/lib/rt.jar \
9090
$(IMAGES_OUTPUTDIR)/lib/resources.jar \
9191
$(IMAGES_OUTPUTDIR)/lib/jconsole.jar \
92-
$(IMAGES_OUTPUTDIR)/lib/ext/dtfj.jar \
93-
$(IMAGES_OUTPUTDIR)/lib/ext/dtfjview.jar \
94-
$(IMAGES_OUTPUTDIR)/lib/ext/traceformat.jar \
9592
$(IMAGES_OUTPUTDIR)/lib/dt.jar \
9693
$(IMAGES_OUTPUTDIR)/lib/tools.jar \
9794
$(IMAGES_OUTPUTDIR)/lib/ct.sym \

0 commit comments

Comments
 (0)
Please sign in to comment.