Skip to content

Commit 9421da3

Browse files
committed
Create noncompressedrefs build (step 1)
- Add config option --with-noncompressedrefs to toggle build - Remove hardcoded references to compressedrefs from makefiles Addition to issue eclipse-openj9/openj9#1669 Signed-off-by: Theresa Mammarella <[email protected]>
1 parent ccbb2b3 commit 9421da3

File tree

5 files changed

+54
-10
lines changed

5 files changed

+54
-10
lines changed

closed/OpenJ9.gmk

-2
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,6 @@ else
9494
OPENJ9_LIBS_OUTPUT_DIR := lib$(OPENJDK_TARGET_CPU_LIBDIR)
9595
endif
9696

97-
OPENJ9_LIBS_SUBDIR := compressedrefs
98-
9997
.PHONY : \
10098
build-j9 \
10199
clean-j9 \

common/autoconf/generated-configure.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3912,7 +3912,7 @@ fi
39123912
#CUSTOM_AUTOCONF_INCLUDE
39133913

39143914
# Do not change or remove the following line, it is needed for consistency checks:
3915-
DATE_WHEN_GENERATED=1524572072
3915+
DATE_WHEN_GENERATED=1525094851
39163916

39173917
###############################################################################
39183918
#

jdk/make/closed/autoconf/custom-hook.m4

+21-3
Original file line numberDiff line numberDiff line change
@@ -144,21 +144,38 @@ AC_DEFUN([OPENJ9_PLATFORM_EXTRACT_VARS_FROM_CPU],
144144

145145
AC_DEFUN_ONCE([OPENJ9_PLATFORM_SETUP],
146146
[
147+
AC_ARG_WITH(noncompressedrefs, [AS_HELP_STRING([--with-noncompressedrefs],
148+
[build non-compressedrefs vm (large heap)])])
149+
147150
OPENJ9_PLATFORM_EXTRACT_VARS_FROM_CPU($build_cpu)
148-
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}_cmprssptrs"
151+
if test "x$with_noncompressedrefs" = x; then
152+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}_cmprssptrs"
153+
OPENJ9_LIBS_SUBDIR=compressedrefs
154+
else
155+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}"
156+
OPENJ9_LIBS_SUBDIR=default
157+
fi
149158
150159
if test "x$OPENJ9_CPU" = xx86-64; then
151160
if test "x$OPENJDK_BUILD_OS" = xlinux; then
152161
OPENJ9_PLATFORM_CODE=xa64
153162
elif test "x$OPENJDK_BUILD_OS" = xwindows; then
154163
OPENJ9_PLATFORM_CODE=wa64
155-
OPENJ9_BUILDSPEC="win_x86-64_cmprssptrs"
164+
if test "x$OPENJ9_LIBS_SUBDIR" = xdefault; then
165+
OPENJ9_BUILDSPEC="win_x86-64"
166+
else
167+
OPENJ9_BUILDSPEC="win_x86-64_cmprssptrs"
168+
fi
156169
else
157170
AC_MSG_ERROR([Unsupported OpenJ9 platform ${OPENJDK_BUILD_OS}!])
158171
fi
159172
elif test "x$OPENJ9_CPU" = xppc-64_le; then
160173
OPENJ9_PLATFORM_CODE=xl64
161-
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_cmprssptrs_le_gcc"
174+
if test "x$OPENJ9_LIBS_SUBDIR" = xdefault; then
175+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_le_gcc"
176+
else
177+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_cmprssptrs_le_gcc"
178+
fi
162179
elif test "x$OPENJ9_CPU" = x390-64; then
163180
OPENJ9_PLATFORM_CODE=xz64
164181
elif test "x$OPENJ9_CPU" = xppc-64; then
@@ -169,6 +186,7 @@ AC_DEFUN_ONCE([OPENJ9_PLATFORM_SETUP],
169186
170187
AC_SUBST(OPENJ9_BUILDSPEC)
171188
AC_SUBST(OPENJ9_PLATFORM_CODE)
189+
AC_SUBST(OPENJ9_LIBS_SUBDIR)
172190
])
173191

174192
AC_DEFUN_ONCE([OPENJDK_VERSION_DETAILS],

jdk/make/closed/autoconf/custom-spec.gmk.in

+2
Original file line numberDiff line numberDiff line change
@@ -67,5 +67,7 @@ OPENJ9_BUILDSPEC := @OPENJ9_BUILDSPEC@
6767
# required by JPP
6868
OPENJ9_PLATFORM_CODE := @OPENJ9_PLATFORM_CODE@
6969

70+
OPENJ9_LIBS_SUBDIR := @OPENJ9_LIBS_SUBDIR@
71+
7072
# Windows
7173
MSVCP_DLL := @MSVCP_DLL@

jdk/make/closed/autoconf/generated-configure.sh

+30-4
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,7 @@ OPENJDK_TAG
869869
OPENJDK_SHA
870870
JDK_FIX_VERSION
871871
JDK_MOD_VERSION
872+
OPENJ9_LIBS_SUBDIR
872873
OPENJ9_PLATFORM_CODE
873874
OPENJ9_BUILDSPEC
874875
OPENJ9_TOPDIR
@@ -1039,6 +1040,7 @@ with_jvm_interpreter
10391040
with_jvm_variants
10401041
enable_debug
10411042
with_debug_level
1043+
with_noncompressedrefs
10421044
with_cuda
10431045
with_gdk
10441046
enable_cuda
@@ -1797,6 +1799,8 @@ Optional Packages:
17971799
[server]
17981800
--with-debug-level set the debug level (release, fastdebug, slowdebug)
17991801
[release]
1802+
--with-noncompressedrefs
1803+
build non-compressedrefs vm (large heap)
18001804
--with-cuda use this directory as CUDA_HOME
18011805
--with-gdk use this directory as GDK_HOME
18021806
--with-conf-name use this as the name of the configuration [generated
@@ -3980,7 +3984,7 @@ fi
39803984

39813985

39823986
# Do not change or remove the following line, it is needed for consistency checks:
3983-
DATE_WHEN_GENERATED=1524572072
3987+
DATE_WHEN_GENERATED=1525094851
39843988

39853989
###############################################################################
39863990
#
@@ -8231,6 +8235,13 @@ $as_echo "$DEBUG_LEVEL" >&6; }
82318235
# With basic setup done, call the custom early hook.
82328236

82338237

8238+
# Check whether --with-noncompressedrefs was given.
8239+
if test "${with_noncompressedrefs+set}" = set; then :
8240+
withval=$with_noncompressedrefs;
8241+
fi
8242+
8243+
8244+
82348245
# Convert openjdk cpu names to openj9 names
82358246
case "$build_cpu" in
82368247
x86_64)
@@ -8250,20 +8261,34 @@ $as_echo "$DEBUG_LEVEL" >&6; }
82508261
;;
82518262
esac
82528263

8253-
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}_cmprssptrs"
8264+
if test "x$with_noncompressedrefs" = x; then
8265+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}_cmprssptrs"
8266+
OPENJ9_LIBS_SUBDIR=compressedrefs
8267+
else
8268+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_${OPENJ9_CPU}"
8269+
OPENJ9_LIBS_SUBDIR=default
8270+
fi
82548271

82558272
if test "x$OPENJ9_CPU" = xx86-64; then
82568273
if test "x$OPENJDK_BUILD_OS" = xlinux; then
82578274
OPENJ9_PLATFORM_CODE=xa64
82588275
elif test "x$OPENJDK_BUILD_OS" = xwindows; then
82598276
OPENJ9_PLATFORM_CODE=wa64
8260-
OPENJ9_BUILDSPEC="win_x86-64_cmprssptrs"
8277+
if test "x$OPENJ9_LIBS_SUBDIR" = xdefault; then
8278+
OPENJ9_BUILDSPEC="win_x86-64"
8279+
else
8280+
OPENJ9_BUILDSPEC="win_x86-64_cmprssptrs"
8281+
fi
82618282
else
82628283
as_fn_error $? "Unsupported OpenJ9 platform ${OPENJDK_BUILD_OS}!" "$LINENO" 5
82638284
fi
82648285
elif test "x$OPENJ9_CPU" = xppc-64_le; then
82658286
OPENJ9_PLATFORM_CODE=xl64
8266-
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_cmprssptrs_le_gcc"
8287+
if test "x$OPENJ9_LIBS_SUBDIR" = xdefault; then
8288+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_le_gcc"
8289+
else
8290+
OPENJ9_BUILDSPEC="${OPENJDK_BUILD_OS}_ppc-64_cmprssptrs_le_gcc"
8291+
fi
82678292
elif test "x$OPENJ9_CPU" = x390-64; then
82688293
OPENJ9_PLATFORM_CODE=xz64
82698294
elif test "x$OPENJ9_CPU" = xppc-64; then
@@ -8276,6 +8301,7 @@ $as_echo "$DEBUG_LEVEL" >&6; }
82768301

82778302

82788303

8304+
82798305
# Source the closed version numbers
82808306
. $SRC_ROOT/jdk/make/closed/autoconf/openj9ext-version-numbers
82818307

0 commit comments

Comments
 (0)