Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unconfigured secrets provider if it is passed via cli args #101

Closed
wants to merge 1 commit into from
Closed

Allow unconfigured secrets provider if it is passed via cli args #101

wants to merge 1 commit into from

Conversation

sl4vr
Copy link
Contributor

@sl4vr sl4vr commented May 21, 2021

If there's get_secret in templates and user passes secret provider via cli argument - it shouldn't raise any exceptions. However if k8t cannot find any secret provider - it will raise.

Fixes #79

@sl4vr sl4vr requested review from AFriemann and a team May 21, 2021 17:20
@sl4vr
Copy link
Contributor Author

sl4vr commented Nov 18, 2022

Closing stale PR

@sl4vr sl4vr closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AFriemann AFriemann Awaiting requested review from AFriemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unconfigured secrets provider crashes k8t
1 participant
@sl4vr