Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SlurmManager readability, add env inheritance #123

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

nefrathenrici
Copy link
Member

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@nefrathenrici nefrathenrici force-pushed the ne/workers branch 2 times, most recently from 7c034ee to 7a4b899 Compare December 19, 2024 00:40
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 9.78261% with 83 lines in your changes missing coverage. Please review.

Project coverage is 17.04%. Comparing base (4152174) to head (a62386e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/workers.jl 0.00% 82 Missing ⚠️
src/backends.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   17.19%   17.04%   -0.15%     
==========================================
  Files           9        9              
  Lines         506      528      +22     
==========================================
+ Hits           87       90       +3     
- Misses        419      438      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nefrathenrici nefrathenrici merged commit 57ae234 into main Dec 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant