Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs for EKP to initialize #92

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add kwargs for EKP to initialize #92

merged 1 commit into from
Jun 17, 2024

Conversation

nefrathenrici
Copy link
Member

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@nefrathenrici nefrathenrici requested a review from costachris June 17, 2024 18:26
Copy link
Member

@costachris costachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this further be exposed and passed through the calibrate function or as additional arguments in the ExperimentConfig?
So if the latter users can do

experiment_config = ExperimentConfig(; n_iterations, ensemble_size, 
                    observations = y_obs, noise = Σ_obs, output_dir, prior, scheduler = EKP.DefaultScheduler(0.5))

slurm_kwargs = kwargs(time = 90, mem="16G")
eki = calibrate(CaltechHPC, experiment_config; slurm_kwargs, verbose=true)

and if the former:

experiment_config = ExperimentConfig(; n_iterations, ensemble_size, 
                    observations = y_obs, noise = Σ_obs, output_dir, prior)

slurm_kwargs = kwargs(time = 90, mem="16G")
eki = calibrate(CaltechHPC, experiment_config; slurm_kwargs, verbose=true, scheduler = EKP.DefaultScheduler(0.5))

@nefrathenrici
Copy link
Member Author

Thanks @costachris, that would be a great addition. I will expose the EKP constructor to calibrate

@costachris
Copy link
Member

Looks good to me, thanks!

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (c56500f) to head (da29045).

Files Patch % Lines
src/backends.jl 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   39.66%   39.66%           
=======================================
  Files           7        7           
  Lines         242      242           
=======================================
  Hits           96       96           
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nefrathenrici nefrathenrici merged commit 8d7ea1c into main Jun 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants