Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more customization options for notes and arrows #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add more customization options for notes and arrows #1

wants to merge 1 commit into from

Conversation

CodeSoftGit
Copy link
Owner

Add more customizability to the NoteTweaks plugin.

  • Configuration/PluginConfig.cs

    • Add new properties for note shapes, arrow shapes, and configuration profiles.

  • UI/SettingsViewController.cs

    • Add UI elements for selecting note shapes, arrow shapes, and configuration profiles.

  • UI/BSML/Settings.bsml

    • Add dropdowns for note shapes and arrow shapes.
    • Add buttons for saving and loading configuration profiles.

  • Managers/MeshManager.cs

    • Add methods for generating new note shapes and arrow shapes.

  • Managers/MaterialManager.cs

    • Add methods for applying new note shapes and arrow shapes.

  • UI/ExtraPanelViewController.cs

    • Add methods for saving and loading configuration profiles.

  • UI/SettingsFlowCoordinator.cs

    • Add methods for handling configuration profile changes.

@CodeSoftGit
Add more customization options for notes and arrows
e908ed8 
Add more customizability to the NoteTweaks plugin.

* **Configuration/PluginConfig.cs**
  - Add new properties for note shapes, arrow shapes, and configuration profiles.

* **UI/SettingsViewController.cs**
  - Add UI elements for selecting note shapes, arrow shapes, and configuration profiles.

* **UI/BSML/Settings.bsml**
  - Add dropdowns for note shapes and arrow shapes.
  - Add buttons for saving and loading configuration profiles.

* **Managers/MeshManager.cs**
  - Add methods for generating new note shapes and arrow shapes.

* **Managers/MaterialManager.cs**
  - Add methods for applying new note shapes and arrow shapes.

* **UI/ExtraPanelViewController.cs**
  - Add methods for saving and loading configuration profiles.

* **UI/SettingsFlowCoordinator.cs**
  - Add methods for handling configuration profile changes.
@CodeSoftGit
Copy link
Owner Author

Cannot work on this until tomorrow

TheBlackParrot
TheBlackParrot reviewed Feb 22, 2025
View reviewed changes
Copy link

@TheBlackParrot TheBlackParrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few questions regarding changes, I'd rather just see a PR with finished code rather than work-in-progress changes

NoteTweaks/Managers/MeshManager.cs
return DefaultArrowShape;
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple things:

  • Note... mesh? We're not changing the shape of the notes themselves, so I'm confused what you're doing here.
  • How come the arrow shape names were replaced with, less describable names?
  • The default mesh, is the default arrow mesh. Why are we now replacing that with a triangle mesh? The default arrow is not just a triangle.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, are your changes to the GenerateFaceMesh function even in this PR? i'm not seeing them

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, are your changes to the GenerateFaceMesh function even in this PR? i'm not seeing them

Im pretty sure i didnt write that i changed GenerateFaceMesh but if i did my bad

@CodeSoftGit CodeSoftGit marked this pull request as draft February 22, 2025 21:57
@CodeSoftGit CodeSoftGit self-assigned this Feb 22, 2025
@CodeSoftGit
Copy link
Owner Author

CodeSoftGit commented Feb 22, 2025 •
edited
Loading

Did this alert you? sorry if it did. I'm just messing around with this. i'll answer your questions as soon as possible :]

@CodeSoftGit
Copy link
Owner Author

this was not intended to become an actual release type thing
just messing around. sorry if this alerted you.
._.

@TheBlackParrot
Copy link

All good! You can pull without submitting a pull request, too; if it's asking you to contribute upstream you can simply ignore it.
I may accept the preset code though, so it's not a complete loss lol

@CodeSoftGit
Copy link
Owner Author

All good! You can pull without submitting a pull request, too; if it's asking you to contribute upstream you can simply ignore it. I may accept the preset code though, so it's not a complete loss lol

if you want i could try to make another pr with a more complete version of the preset code only

@TheBlackParrot
Copy link

if you want to, sure!

@CodeSoftGit
Copy link
Owner Author

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlackParrot TheBlackParrot TheBlackParrot left review comments

Assignees

@CodeSoftGit CodeSoftGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeSoftGit @TheBlackParrot