Custom Header in Elementor Pro affects the shop page layout

[poonam279]

Description

When using Elementor Pro to create a custom header for the shop page, the page displays in full width regardless of the container width setting (set to "contained"). This issue overrides the intended layout and affects the shop page's appearance.

I have rolled back to version 3.8.14 and it shows the correct layout.

Step-by-step reproduction instructions

1. Create a custom header using Elementor Pro.
2. Assign the header to display on the shop page.
3. Set the container width to "contained" in the theme settings.
4. View the shop page on the front end.

Screenshots, screen recording, code snippet or Help Scout ticket

HS: https://secure.helpscout.net/conversation/2801107488/446655

Shop page with version 3.8.14

Shop page with version 3.8.16

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

[girishpanchal30]

@poonam279 I've reviewed this issue and fixed it with this PR #4350, Please check with the build zip and let me know if you encounter any issues.

[poonam279]

@girishpanchal30 I have tested the PR but it doesn't resolve the issue.

You can check it here.
https://humgovernor.s3-tastewp.com/91fa9-pro-shop/
Admin area URL: https://humgovernor.s3-tastewp.com/wp-admin
Username: poonam
Password: PBe2-gKkIi8

[girishpanchal30]

@poonam279 From my side, it looks like the screenshot below. Could you please share what issue occurred on your end?

[girishpanchal30]

Additionally, your test instance is missing some HTML elements, and I'm not sure why it differs from my local setup.

[poonam279]

@girishpanchal30, it appears that you didn't add the custom header created with elementor Pro on the shop page that's why the layout seems okay on your end. The issue occurred when we add a Elementor header on shop page. Can you please try?

[girishpanchal30]

@poonam279 Thank you! It looks like Elementor ignored the theme's header path, causing it to miss the 'Neve' theme's header hooks. I’ve made some fixes to resolve this.

Please test with the latest build zip and let me know if you encounter any issues.

Thanks!

[poonam279]

@girishpanchal30 It fixes the fullwidth layout issue but I noticed two other issues

• content width in the customizer has no effect on the shop page
• the left and right sidebar are not appearing as expected

[rodica-andronache]

Just a note here, for who's testing, this is not happening just when using a Custom Header. It's actually happening no matter what Template you choose from Elementor https://vertis.d.pr/i/LKuDKF ( footer, header etc ). If you make it appear on the Shop page https://vertis.d.pr/i/fpn0JS, the Shop page layout is broken, and the header is missing.

[girishpanchal30]

@rodica-andronache Thank you for the feedback! I've reviewed the issue you mentioned and resolved it in the latest commit.

[rodica-andronache]

@girishpanchal30 the initial issue is fixed, but with this new version of Neve, I'm not able to add a Template in Elementor anymore

Video with the current version versus the new one https://vertis.d.pr/v/QMJYeB

[girishpanchal30]

@rodica-andronache Fixed mentioned error, please check with the latest build zip.

[rodica-andronache]

+1 https://secure.helpscout.net/conversation/2834566314/451857

[poonam279]

+1 https://secure.helpscout.net/conversation/2837098677/452613

[rodica-andronache]

@girishpanchal30 thanks for the fix, now I'm able to add templates in Elementor. But saw other thing not working. When I don't have any Templates created in Elementor, and I choose to have a sidebar on the Shop page https://vertis.d.pr/i/UlEpE4 , the sidebar appears at the bottom of the shop page https://vertis.d.pr/i/Vgn5Xc. As you can see it here https://rodicaelena.com/shop/

Also, maybe it would be a good idea to also get the changes done on the development branch in this PR? I'm asking because the latest release of Neve has a lot of changes in the customizer, that might impact this as well.

[rodica-andronache]

+1 https://secure.helpscout.net/conversation/2842352385/453824?viewId=212385

[girishpanchal30]

Also, maybe it would be a good idea to also get the changes done on the development branch in this PR? I'm asking because the latest release of Neve has a lot of changes in the customizer, that might impact this as well.

@rodica-andronache I've rebased the branch with the development branch. Could you check the latest build zip and let me know if you encounter any errors?

Thanks!

[poonam279]

+1 https://secure.helpscout.net/conversation/2847401928/454487

[rodica-andronache]

+1 https://secure.helpscout.net/conversation/2859151290/455814?viewId=212385

[rodica-andronache]

@girishpanchal30 this is still not fixed:

When I don't have any Templates created in Elementor, and I choose to have a sidebar on the Shop page https://vertis.d.pr/i/O8K6PZ , the sidebar appears at the bottom of the shop page https://vertis.d.pr/i/jT72Sn
https://exultant-lyrebird-2a7919.vertisite.cloud/shop/

[girishpanchal30]

@rodica-andronache I've addressed the mentioned issue in the latest commit. Please test it with the newest build zip and let me know if you encounter any issues.

[rodica-andronache]

@girishpanchal30 that is fixed, but found other thing that's not working.
On the blog page ( Your latest posts ), when I create a Footer in Elementor that applies to the entire site, the header from the theme is disappearing on that page.
I've created a video showcasing this https://vertis.d.pr/v/ZgHNoJ

[girishpanchal30]

@rodica-andronache When I reviewed the Elementor header-footer codebase, I found that the Elementor plugin loads its own templates if a header or footer location is set, removing both theme templates.

If we try to forcefully load the theme template, it might cause other issues, such as a broken HTML structure, as shown below.

Thanks

[rodica-andronache]

+1 https://secure.helpscout.net/conversation/2867921952/456979?viewId=212385

[vytisbulkevicius]

@girishpanchal30, do you know which change in v3.8.15 caused this issue? I see that in original comment @poonam279 mentioned that when she rolled back to 3.8.14 it works fine and 3.8.15 did not have a lot of changes, can't we revert the change that made it broken?

This is being reported by a lot of users already so we need to have a fix

[girishpanchal30]

do you know which change in v3.8.15 caused this issue?

@vytisbulkevicius In v3.8.15, we reverted my _load_textdomain_just_in_time changes and released a new version.
Ref:4bf6140

In v3.8.14, I changed the Neve theme core hooks loading, which might have worked but introduced additional issues. As a result, @selul reverted my changes and released v3.8.15.

@poonam279 Could you please check with v3.8.13 or v3.8.12 and let me know if it works?

Thanks!

[rodica-andronache]

@girishpanchal30 I've tested all past versions until 3.8.11 and the only one where this issue with Elementor PRO is not happening is Neve 3.8.14.

Also, in 3.8.14 the issue with _load_textdomain_just_in_time is not happening.

cc @vytisbulkevicius

[girishpanchal30]

@rodica-andronache After we release Neve 3.8.14 with my changes related to _load_textdomain_just_in_time, this PR fixes the issues. However, these changes have introduced another issue due to my changes.

@selul has reverted my changes with this PR and released Neve 3.8.15.

So, it looks like it's not a regression issue; the issue also exists in an older version.

cc @vytisbulkevicius

Thanks

[selul]

@vytisbulkevicius I think this requires carefully analysis, mayeb @abaicus can include this when he will work on the new release.

[selul]

@vytisbulkevicius I think we can also drop the regression tag since this is not a critical regression that @ineagu asked about during the PRF monitoring.

[vytisbulkevicius]

Ok. This was brought by support team several times as customers are actively asking about the fix so that's why we were working on it but it's a high risk to introduce some other regression based on the progress with the fixes so we can wait for Andrei to take a look.

@Codeinwp/support we can tell customers that we are still investigating this and at this time, we cannot provide an estimated resolution date for the issue as it's more complex.

[selul]

@vytisbulkevicius the load early notice is a warning that shows only when debug is active, it has no impact on functionality to rush this.

[vytisbulkevicius]

@selul, yes, but this issue is not about it, what users are reporting is what this issue is named and created for:
Custom Header in Elementor Pro affects the shop page layout

[selul]

In this case why that notice that Ive reverted matters here?

[selul]

Also I see that Rodica mentioned that this is happening to more older versions aswell, hence is a regression of the latest.

[vytisbulkevicius]

So based on tests that @rodica-andronache made this issue "Custom Header in Elementor Pro affects the shop page layout" was happening before and was fixed with 3.8.14 where also the notice was fixed but since it caused many issues you reverted the changes on 3.8.15 and since then both this issue and notice are present again.

So this isn't a regression really as it was fixed only in version 3.8.14.

[rodica-andronache]

I don't know if this is relevant or not, but Elementor and Elementor PRO also had their own updates in the meantime, so there is a chance that some old versions of Neve worked well with the Elementor versions at that time, making users think that the problem is coming from the latest updates of Neve.

[rodica-andronache]

+1 https://secure.helpscout.net/conversation/2883169256/459477?viewId=937d6f8f-5b3a-4f71-abfd-4d038f115f48