Skip to content

Commit cb5a4d1

Browse files
Feat/upgrade lerna+npm workspace (usecannon#234)
* Upgraded lerna version * Upgraded @babel/core dependency which had vulnerability * Upgraded registry-subgraph dependencies * Migrated to npm workspace * remove lerna bootstrap * remove lerna bootstrap / 2 * Fixed tsconfig.json issues * Fixed linting issues * Fixed solhint issues * Fixed website generate issue * update README.md * empty commit --------- Co-authored-by: Matías <[email protected]>
1 parent 776d3f7 commit cb5a4d1

29 files changed

+82427
-143224
lines changed

.github/workflows/lint.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ jobs:
1515
with:
1616
cache: npm
1717
node-version: '16.16.0'
18-
- run: |
19-
npm ci
20-
npx lerna bootstrap
18+
- run: npm ci
2119
- run: npm run lint:js
2220
- run: npm run lint:sol

.github/workflows/test.yml

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ jobs:
1717
node-version: '16.16.0'
1818
- run: |
1919
npm ci
20-
npx lerna bootstrap
2120
npm run build
2221
- run: cd ./packages/builder && npm test
2322
- run: cd ./packages/registry && REPORT_GAS=1 npm test

.github/workflows/verify.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@ jobs:
3939
node-version: ${{ matrix.node-version }}
4040
cache: 'npm'
4141
- run: npm ci
42-
- run: npx lerna bootstrap
4342
- run: npm run build
4443
- run: cd ./packages/sample-hardhat-project && npm run test

.solhint.json

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"compiler-version": ["error", "^0.8.0"],
99
"contract-name-camelcase": "off",
1010
"func-visibility": ["error", { "ignoreConstructors": true }],
11+
"no-console": "off",
1112
"no-complex-fallback": "off",
1213
"no-inline-assembly": "off",
1314
"private-vars-leading-underscore": ["error", { "strict": false }],

README.md

+3-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ For more information, please see documentation in the modules listed below:
2020

2121
Community contributions to Cannon are greatly appreciated. Please open pull requests, issues, and discussions in the GitHub repository.
2222

23-
To load a development version of Cannon, start by bootstrapping the project from the root directory:
23+
To load a development version of Cannon, start by installing the dependencies from the root directory:
2424

2525
```
26-
npx lerna bootstrap
27-
npm i
26+
npm ci
2827
```
2928

3029
After making changes, rebuild the project:
@@ -53,7 +52,7 @@ cd ./packages/website && npm run dev
5352

5453
### Publishing
5554

56-
With appropriate permissions on npm, publish updates using the [lerna publish](https://github.com/lerna/lerna/tree/main/commands/publish) command. For example, `npx lerna publish patch` will publish updated packages as the next patch version.
55+
With appropriate permissions on npm, publish updates using the [npx lerna publish](https://github.com/lerna/lerna/tree/main/commands/publish) command. For example, `npx lerna publish patch` will publish updated packages as the next patch version.
5756

5857
## License
5958

lerna.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
{
2-
"packages": [
3-
"packages/*"
4-
],
2+
"npmClient": "npm",
53
"version": "2.4.15"
64
}

0 commit comments

Comments
 (0)