-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few UI requests or suggestions #21
Comments
I am too lazy to create a pull request so here is slightly modified UI.cs incorporating my suggestions 3 and 4. The default output filename is "deoldified", later it becomes "[inputfile]-deoldified".
|
Good afternoon! Thanks for the suggestions, they are really helpful. I will review them in the near future and make edits to the code. |
Done.
Done.
Done.
It also makes sense to implement. If you open the wrong image, you can immediately stop the process and select another file. I will redo the start/stop button.
The request for this function has been present for a long time and I first studied this issue a few months ago. This is not so easy to implement, since the Windows application and the console application run differently. Hybrid mode is possible, however, its implementation requires the use of WinAPI, which excludes work on non-Windows systems. The issue requires more detailed study. |
On the 5th point. The easiest way is to make an option to compile the program into a console application. It is unlikely that someone who uses a GUI will suddenly need a CLI, as well as vice versa. Most likely I will prepare 2 versions of the program. Hybrid mode is possible, however, it refers to hacks running on specific versions of operating systems, and correctness is not guaranteed. The console version will probably get Android support. |
I apologize for yet another UI suggestion... =]
|
Thanks for creating this port of DeOldify, It's really nice to be able to simply run it from Windows but I think some details could be changed to make it even smoother for the repeated usage.
Support for drag and drop of input file would be really nice
I think the button to run the colorization process is rather redundant. Unless you open a wrong file you just want to run the colorization process immediately so I think getting rid of the extra button would save one (un)necessary click for most users.
The save dialog should pre-populate the file name textbox with the original file name. I think most users want to use a new name derived from the original one so it would save them some typing,
The file mask should definitely change the descriptions in order to enable selecting the right format by pressing just one key and not by pressing "I" several times. =}
I.e. the line number 680 in UI.cs:
SFD.Filter = "Images (*.bmp)|*.bmp|Images (*.emf)|*.emf|Images (*.exif)|*.exif|Images (*.gif)|*.gif|Images (*.ico)|*.ico|Images (*.jpg)|*.jpg|Images (*.png)|*.png|Images (*.tiff)|*.tiff|Images (*.wmf)|*.wmf";
should change to this:
SFD.Filter = "BMP images (*.bmp)|*.bmp|EMF images (*.emf)|*.emf|EXIF images (*.exif)|*.exif|GIF images (*.gif)|*.gif|Icons (*.ico)|*.ico|JPEG jmages (*.jpg)|*.jpg|PNG images (*.png)|*.png|TIFF images (*.tiff)|*.tiff|WMF images (*.wmf)|*.wmf";
What about an option to run the app from command line just in console mode?
Just my two cents... =)
The text was updated successfully, but these errors were encountered: