add test on beforeunload bug

Author: christian-byrne

tests/integration/appWindow.spec.ts

@@ -13,3 +13,23 @@ test('App quits when window is closed', async ({ app }) => {
   await window.close();
   await app.app.waitForEvent('close');
 });
+
+test('App can quit when graph has unsaved changes', async ({ graphCanvas, installWizard, installedApp }) => {
+  await installWizard.stepThroughOnboarding();
+  await graphCanvas.expectLoaded();
+
+  // Create a workflow and add unsaved changes
+  await installedApp.createBlankWorkflow();
+  await installedApp.saveWorkflow();
+  await installedApp.addFirstNodeResult();
+
+  // Wait for change tracker
+  await installedApp.window.waitForTimeout(1024);
+
+  // Ensure beforeunload dialog is not raised and app can quit normally
+  // (https://github.com/Comfy-Org/desktop/issues/688)
+  await installedApp.window.close({
+    runBeforeUnload: true,
+  });
+  await installedApp.window.waitForEvent('close');
+});

tests/integration/testInstallWizard.ts

@@ -5,12 +5,14 @@ export class TestInstallWizard {
   readonly nextButton;
   readonly cpuToggle;
   readonly installLocationInput;
+  readonly installButton;
 
   constructor(readonly window: Page) {
     this.nextButton = this.getButton('Next');
     this.getStartedButton = this.getButton('Get Started');
     this.cpuToggle = this.window.locator('#cpu-mode');
     this.installLocationInput = this.getInput('', true);
+    this.installButton = this.getButton('Install');
   }
 
   async clickNext() {
@@ -28,4 +30,19 @@ export class TestInstallWizard {
   getInput(name: string, exact?: boolean) {
     return this.window.getByRole('textbox', { name, exact });
   }
+
+  async stepThroughOnboarding() {
+    await this.clickGetStarted();
+    await this.cpuToggle.click();
+    await this.clickNext();
+    await this.clickNext();
+    await this.clickNext();
+    await this.installButton.click();
+
+    // Wait for app to be ready
+    await this.window.waitForFunction(() => {
+      // @ts-expect-error window is not typed
+      return window['app'] && window['app'].extensionManager;
+    });
+  }
 }

tests/integration/testInstalledApp.ts

@@ -18,4 +18,30 @@ export class TestInstalledApp {
       await expect(this.blockUi).not.toBeVisible();
     }).toPass({ timeout, intervals: [500] });
   }
+
+  /** Creates a new blank workflow using the button in the tabs */
+  async createBlankWorkflow() {
+    const newWorkflowButton = this.window.getByLabel('Create a new blank workflow');
+    await newWorkflowButton.click();
+  }
+
+  /** Saves the current workflow using keyboard shortcuts. */
+  async saveWorkflow() {
+    await this.window.keyboard.press('Control+S');
+    await this.window.waitForSelector('#global-prompt', { state: 'visible' });
+    await this.window.keyboard.press('Enter');
+    await this.window.waitForSelector('#global-prompt', { state: 'hidden' });
+  }
+
+  /** Opens the node searchbox by double clicking on the canvas. */
+  async openNodeSearchbox() {
+    await this.window.mouse.dblclick(256, 256, { delay: 128 });
+    await this.window.waitForSelector('.p-autocomplete');
+  }
+
+  /** Opens the node searchbox and adds the first result to the graph. */
+  async addFirstNodeResult() {
+    await this.openNodeSearchbox();
+    await this.window.keyboard.press('Enter');
+  }
 }