Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy strategy link doesn't add / remove files to magento-root-dir/.gitignore and doesn't remove files from disk on composer remove package/x #167

Open
branb opened this issue Aug 8, 2017 · 3 comments

Comments

@branb
Copy link

branb commented Aug 8, 2017

As the title says, with deploy strategy link (e.g. hard links), upon issuing composer require package/x, sometimes no files or just some files are added to magento-root-dir/.gitignore.

Also, when issuing composer remove package/x, files are also not removed from the magento-root-dir either.

I tested this with various extensions and with my own extension, which only had 4 files. For my own extension, no files were added to .gitignore at all and in the case of the tested extensions from the firegento repo some files were missing from the .gitignore, most of the time files that are not in app/code/, e.g. files in skin/ or app/design/* etc.

Tested extensions were for example:

  • "aoepeople/aoe_scheduler": "^1.5" or
  • "connect20/ASchroder_SMTPPro": "^2.0"

Only changing the deploy strategy to something like symlink "fixes" this, e.g. .gitignore is populated as expected and files are deleted on composer remove as well.

@hhirsch
Copy link

hhirsch commented May 4, 2018

@branb I can reproduce this!

@branb
Copy link
Author

branb commented May 4, 2018

@hhirsch Did you experience this with a custom extension or with one from a public repository?

@hhirsch
Copy link

hhirsch commented May 4, 2018

@branb I've rolled these myself. I am sure it is for every package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants