Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git submodule to handle external dependence #454

Open
pcchen opened this issue Aug 30, 2024 · 1 comment
Open

Use git submodule to handle external dependence #454

pcchen opened this issue Aug 30, 2024 · 1 comment

Comments

@pcchen
Copy link
Collaborator

pcchen commented Aug 30, 2024

I want to discuss the possibility of using git submodule to handle external dependence. There are three main dependences

  • boost
  • pybind11
  • openblas (if MKL is not used)

I find that, on Ubuntu Linux (2x.x), if I use apt to install libopenblas*, it does not contain lapacke.h. If you also install liblapacke-dev, then you can compile cytnx. But when you import cytnx, it will complain undefined symbol: LAPACKE_dstev. Finally I find that the libopenblas.so does not have LAPACKE_* symbols.

If you download, compile, and install OpenBLAS, say in /opt/OpenBLAS. (It is easy). Then your compiled libopenblas.so DO have LAPACKE_* symbols and you have head file lapacke.h in /opt/OpenBLAS/include.

Since openblas and pybind11 are not difficult to install. It might be a good idea to use git submodule to handle them to have better control, consistence. and is easier to debug the build process.

In https://github.com/tensor4all/xfac , they use git submodule to handle pybind11 dependence.

Also, since we only need a very small part of the boost, mabye we can only include this small part as a submodule?

@jeffry1829
Copy link
Collaborator

If I recall correctly, there has been attempt to do that, I'll investigate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants